April 2018 - Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #61 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- *Has everything been addressed? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #60 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- (In reply to M. Tompsett from comment #58) > The function name is decimal_from_string. It's not intuitive to return false. It doesn't make sense to return false, removing it. > Also, why do a is_decimal check in this function and the calling function? Because I missed this when refactoring the legacy patch ^^ Thanks for catching this :) > Just do the assignment, and make sure the decimal_from_string returns what was passed, if it isn't a decimal. It doesn't touch the content when the input isn't a number. I feared that there might cases where this could be confusing or annoying. (to always unformat the field) I wasn't confident enough that I wouldn't create edge cases issues. But other opinions are welcome and I will change that if we consider safe to always unformat the field. After considering that this feature could be used on all decimal fields of Koha. > placeholder="Example 5.00" When the syspref equals "," to use the dots as thousand separators. Then this placeholder or tip wouldn't make sense. Has everything be addressed? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73657|0 |1 is obsolete| | --- Comment #59 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 73784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73784&action=ed… Bug 12310 : Decimal separator issues: some fixes in fines The main goal is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator Bonuses: - Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator. It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DigitSeparator syspref. - minuses, doesn't remove them - non-decimal values: it doesn't touch them == Test plan == 1. Use a translation of the staff interface if possible. 2. When you pay an existing fine (more details in the next steps if needed). Check that you can't enter any string except like "XX.XX" (examples in Annex 1) without having an issue after validation. (x100, truncation, etc) 3. Apply this patch 4. run ~/src/installer/data/mysql/updatedatabase.pl 5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 6. Apply the annex 1 to the "Amount" field 7. When paying a fine (cgi-bin/koha/members/paycollect.pl) 8. Click on "Pay amount" to go to the page to pay all fines 9. Apply the annex 1 to the "Collect from patron" field 10. Click on "Pay" to go to the page to pay fine 11. Apply the annex 1 to the "Collect from patron" field 12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 13. Apply the annex 1 to the "Amount" field 14. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. (and prevent me from having bounty on my head) 15. Express your happiness. This is important, otherwise the sign off spell won't work! The details of expressing your happiness depend on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. What follows is just a list of examples. They don't have to be tried on each field. 6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" 7. Same with "EUR 12.34" -> "12.34" 8. "EUR 12.34€hi lyonthree" -> "12.34" 9. "123 456,7" -> "123456.7" 10. "2" -> "2" 11. "2,0" -> "2.0" 12. "-1'345.95" -> "-1345.95" 13. ",1234" -> ".1234" 14. Set DecimalSeparators syspref to "," 15. Reload the page with the form 16. "1.000" -> "1000" 17. "1.000.000,10" -> "1000000.10" 18. Set DecimalSeparators syspref to "." 19. Reload the page with the form 20. "1,000" -> "1000" 21. "1,000,000.10" -> "1000000.10" 22. Validate the form and check that the final value with the dot was well handled. 23. Think about Koalas and smile. 🐨🐨🐨 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #39 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73783&action=ed… Bug 9701: Followup to make test pass Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #38 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73782&action=ed… Bug 9701: (follow-up) Adjust tests Test plan: prove t/db_dependent/Biblio.t should be green Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #37 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73781&action=ed… Bug 9701: (QA follow-up) Fix indentation and some strings - Fixes tabs pointed out by the QA script. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72010|0 |1 is obsolete| | Attachment #72011|0 |1 is obsolete| | Attachment #72012|0 |1 is obsolete| | Attachment #72986|0 |1 is obsolete| | --- Comment #36 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73780&action=ed… Bug 9701: Configure default indicator This patch adds the possibility to define default indicators in the MARC frameworks. It adds 2 columns in the marc_tag_structure table in the database in order to accomplish this. All files that reference this table have also been updated to reflect these added fields. Test: Add or edit a MARC framework. In the Field list should be 2 extra columns. It should be possible to add default indicators (1 character) in these fields. Nothing else should have changed in the meantime. The default indicator values are not yet visible in the cataloguing module. The default values are also loaded in the cataloguing form. Test: Define default values in some MARC framework. Go to cataloguing and create a new record using this framework. Verify that the defined defaults are visible when set. Verify the default is empty (as before) if no default was set. Verify that if the default is changed, the record is saved with the manually changed value. Verify that upon changing such a new record, the manually set indicator value is used and not the default one from the framework. Don't forget to run database and database schema update Signed-off-by: Eugene Jose Espinoza <eugenegf(a)yahoo.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19997] New: use Modern::Perl in Circulation perl scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Bug ID: 19997 Summary: use Modern::Perl in Circulation perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com use Modern::Perl should be used instead of use strict; use warnings; Relevant in: bookcount.pl branchoverdues.pl branchtransfers.pl circulation.pl hold-transfer-slip.pl reserveratios.pl returns.pl selectbranchprinter.pl transfer-slip.pl transferstoreceive.pl view_holdsqueue.pl waitingreserves.pl ypattrodue-attr-search-authvalue.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 19993] New: use Modern::Perl in Acquisition perl scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Bug ID: 19993 Summary: use Modern::Perl in Acquisition perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: acqui/spent.pl acqui/supplier.pl acqui/uncertainprice.pl acqui/updatesupplier.pl acqui/z3950_search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13