April 2018 - Koha-bugs - lists.koha-community.org

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #58 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 73657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73657 Bug 12310 : Decimal separator issues: some fixes in fines Review of attachment 73657: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=123…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/decimal-input-js.inc @@ +16,5 @@ > + } > + > + var decimal_from_string = function(formatted_decimal) { > + if (!is_decimal(formatted_decimal)) { > + return false; The function name is decimal_from_string. It's not intuitive to return false. Why not just return what was passed when it isn't a decimal? Which leads to the question, why call the parameter formatted_decimal if there is a is_decimal check? It is just a formatted_value. It may or may not be a decimal. Also, why do a is_decimal check in this function and the calling function? @@ +34,5 @@ > + * to care about decimal separators (see DecimalSeparators syspref) and > + * currency symbols for example. > + */ > + handler_unformat_input: function(field) { > + if (is_decimal(field.value)) { Why do a is_decimal check here and in the decimal_from_string function? Just do the assignment, and make sure the decimal_from_string returns what was passed, if it isn't a decimal. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt @@ -40,4 @@ > <li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li> > <li><label for="desc">Description: </label><input type="text" name="desc" size="50" id="desc" /></li> > <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li> > - <li><label for="amount">Amount: </label><input type="number" name="amount" id="amount" required="required" value="" step="any" min="0" /> Example: 5.00</li> placeholder="Example 5.00" would be a better solution than cutting this. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt @@ -53,4 @@ > <li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li> > <li><label for="desc">Description: </label><input type="text" name="desc" id="desc" size="50" /></li> > <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li> > - <li><label for="amount">Amount: </label><input type="number" name="amount" id="amount" required="required" value="" step="any" min="0" /> Example: 5.00</li> placeholder="Example 5.00" is a better solution. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20408 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset(a)biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73549|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 73691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73691&action=ed… Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <<cat>> AS one, <<dog|branches>> AS two, <<dog|YES_NO>> as three, <<cat>> as four, <<dog|branches>> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phas… 9 - Verify results come out as expected. i.e. 5 different values that are those of the URL. Signed-off-by: Victor Grousset <victor.grousset(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15296] MEMBER logging in action_logs does not give enough detail.
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15296 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73668|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 73679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73679&action=ed… Bug 9302: (QA follow-up) Consistency follow-up This patch moves the Koha::Patrons->merge method into Koha::Patron->merge_with in the line of the discussed implementation for bug 15336. I agree with that implementation so I provide this follow-up. Tests are adjusted, the controller script is adapted too. The behaviour remains. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14420] bulkmarcimport.pl - Some problems
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 --- Comment #6 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Vitor Fernandes from comment #0) > PROBLEM 1 > > If a record as some than one ISBN, the values are recorded in database like > 'isbn1 | isbn2 | isbn3'. > > In the script the ISBN match are only checking for exact ISBN matching. This is because: 020 - International Standard Book Number (R) -- The 020 field is repeatable. This is clearly bad data, but yes, we should attempt to parse for it. I don't like the multiple likes fix provided here. I would prefer a: my @isbns = parseIsbnField($isbn_field_value); foreach my $isbn (@isbns) { search for the individual isbn ... } sub parseIsbnField { my ($isbn_data) = @_; see if we can split out some ISBNs. ... return an array of the results. } -- You are receiving this mail because: You are watching all bug changes.

1 0