April 2018 - Koha-bugs - lists.koha-community.org

[Bug 11512] Forced holds that violate issuing rules will never be filled
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73173|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73735&action=ed… Bug 11512: Update syspref description Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11512] Forced holds that violate issuing rules will never be filled
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '18

06 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72689|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73734&action=ed… Bug 11512 - Forced holds that violate issuing rules will never be filled Currently in Koha, if you choose to force a hold from the staff side that would contravened the current issuing rules, that hold will never be filled, as it is always skipped over by CheckReserves. This patch disallows overrideing except for tooManyReserves which are the only overridden holds that will be trapped. Test Plan: 1) Apply this patch 2) Attempt to override hold placement, only placements where the patron has too many holds already should be allowed Signed-off-by: Jesse Maseto <jesse(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, Go to "Default checkout, hold and return policy", you do not see "Total holds allowed", fill the other fields, save: default_circ_rules.holdallowed is filled. We could add it to the interface and make it configurable, do not you think? Also if we add "max_holds", maybe we should rename "holdallowed" then. After that is done, the code in CanItemBeReserved could be replaced with a call to GetBranchBorrowerCircRule. Without these changes we add more confusion to the code in my opinion. I will not have the time to provide such change before the release. Setting to in discussion to get other QAer opinions on these patches. Feel free to provide a patch if you think my requests make sense to you. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11405] Inventory tool enhancements
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15471] Add column settings and filters to Holds queue table
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20530 [Bug 20530] trailing ':' in columns_settings.yml -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #58 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 73657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73657 Bug 12310 : Decimal separator issues: some fixes in fines Review of attachment 73657: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=123…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/decimal-input-js.inc @@ +16,5 @@ > + } > + > + var decimal_from_string = function(formatted_decimal) { > + if (!is_decimal(formatted_decimal)) { > + return false; The function name is decimal_from_string. It's not intuitive to return false. Why not just return what was passed when it isn't a decimal? Which leads to the question, why call the parameter formatted_decimal if there is a is_decimal check? It is just a formatted_value. It may or may not be a decimal. Also, why do a is_decimal check in this function and the calling function? @@ +34,5 @@ > + * to care about decimal separators (see DecimalSeparators syspref) and > + * currency symbols for example. > + */ > + handler_unformat_input: function(field) { > + if (is_decimal(field.value)) { Why do a is_decimal check here and in the decimal_from_string function? Just do the assignment, and make sure the decimal_from_string returns what was passed, if it isn't a decimal. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt @@ -40,4 @@ > <li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li> > <li><label for="desc">Description: </label><input type="text" name="desc" size="50" id="desc" /></li> > <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li> > - <li><label for="amount">Amount: </label><input type="number" name="amount" id="amount" required="required" value="" step="any" min="0" /> Example: 5.00</li> placeholder="Example 5.00" would be a better solution than cutting this. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt @@ -53,4 @@ > <li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li> > <li><label for="desc">Description: </label><input type="text" name="desc" id="desc" size="50" /></li> > <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li> > - <li><label for="amount">Amount: </label><input type="number" name="amount" id="amount" required="required" value="" step="any" min="0" /> Example: 5.00</li> placeholder="Example 5.00" is a better solution. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20408 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '18

05 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset(a)biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

1 0