May 2018 - Koha-bugs - lists.koha-community.org

[Bug 11983] code to select patrons to purge needs to be centralized
by bugzilla-daemon＠bugs.koha-community.org 25 May '18

25 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |martin.renvoize@ptfs-europe | |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11512] Only allow to override maximum number of holds from staff as other overrides would never be filled
by bugzilla-daemon＠bugs.koha-community.org 25 May '18

25 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Stefan Berndtsson <stefan.berndtsson(a)ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson(a)ub.gu.se --- Comment #14 from Stefan Berndtsson <stefan.berndtsson(a)ub.gu.se> --- (In reply to Marcel de Rooy from comment #11) > Currently in Koha, if you choose to force a hold from the staff side that > would contravened the current issuing rules, that hold will never be filled, > as it is always skipped over by CheckReserves. > > This patch disallows overrideing except for tooManyReserves which are the > only overridden holds that will be trapped. >From what I can see in the code, this isn't actually true. CheckReserves does not include neither LOST nor WITHDRAWN in its checks. In fact, we use the LOST part here. When longoverdue.pl marks a book as LOST, our staff adds a reserve to that item, so that they will be notified if it is returned. With the code prior to this patch, this works perfectly fine since we have the AllowHoldPolicyOverride set and returning a LOST item fills the hold. We've also used a similiar thing with withdrawn, but that's not as critical, so I won't argue against that one. The assumption that this is always skipped is not valid, unless I've missed something. We can patch things temporarily, but some sort of option for better override selectability would probably be useful here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2426] Management permissions is deprecated
by bugzilla-daemon＠bugs.koha-community.org 25 May '18

25 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75476|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75562&action=ed… Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2426] Management permissions is deprecated
by bugzilla-daemon＠bugs.koha-community.org 25 May '18

25 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2426] Management permissions is deprecated
by bugzilla-daemon＠bugs.koha-community.org 25 May '18

25 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs(a)lists.koha-commun |m.de.rooy(a)rijksmuseum.nl |ity.org | CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- > Bonus: > borrowers.flags is recalculated for patrons with management > permission. No bonus imo. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 17739] New: Opac explodes when clicking on user tag when using elastic
by bugzilla-daemon＠bugs.koha-community.org 25 May '18

25 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17739 Bug ID: 17739 Summary: Opac explodes when clicking on user tag when using elastic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The log says: Can't locate object method "subfield" via package "<?xml version="1.0" encoding="UTF-8"?><record .. whole xml record" at C4/Search.pm line 1925 To reproduce 1) Set syspref SearchEngine to Elastic 2) go to opac detail and add a tag 3) try to click the added tag -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 25 May '18

25 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12004] Regional preference on holds
by bugzilla-daemon＠bugs.koha-community.org 24 May '18

24 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12004 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20747 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 11126] Make the holds system optionally give precedence to local holds
by bugzilla-daemon＠bugs.koha-community.org 24 May '18

24 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20747 CC| |lisetteslatah(a)gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
by bugzilla-daemon＠bugs.koha-community.org 24 May '18

24 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0