May 2018 - Koha-bugs - lists.koha-community.org

[Bug 19176] New: Dates comparison fails on slow server
by bugzilla-daemon＠bugs.koha-community.org 23 May '18

23 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Bug ID: 19176 Summary: Dates comparison fails on slow server Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org # Failed test 'borrowers.updated_on should have been set to now on creating' # at t/db_dependent/Patrons.t line 74. # got: '2017-08-10T20:53:03' # expected: '2017-08-10T20:53:04' # Looks like you failed 1 test of 17. [20:53:15] t/db_dependent/Patrons.t ..................................... -- You are receiving this mail because: You are watching all bug changes.

1 35

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- > I (In reply to Katrin Fischer from comment #11) > > But couldn't they change the home library in their records too? > > I think in general we got a problem there, that you can get around the > > limits, maybe the logged-in library is more helpful? > > I think this should be the user's logged in library - for extra protection I > think the library would implement AutoLocation and limit logged in site by > ip so this would require some extra steps but would also be a first level > guard against accidentally altering other rules A lot of the public and smaller libraries here don't have static IP addresses, so AutoLocation is not good. But it's a problem we should solve on this bug report! I think the new permission adds an extra barrier as a good first step and it will prevent people from accidentally editing the wrong library's rules. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2426] Management permissions is deprecated
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75349|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 75476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75476&action=ed… Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2426] Management permissions is deprecated
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7651] Add separate permission for managing currencies and exchange rates
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Ah yes, I will make administration start page and administration links in acq consistent! Thx for testing! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7651] Add separate permission for managing currencies and exchange rates
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- > 2) parameters > 3) parameters_remaining_permissions > 4) manage_circ_rules, but not parmeters_remaining_permissions Testing these different users, I don't see the acquisitions-related links on the Adminstration home page but I do see them in the sidebar when I view an administration page which I have permission to view. (Not related to this patch, but I see that with only manage_circ_rules set, the user sees the same Administration home page links as the user above even though they only have access to circ rules). > 5) all acquisition permissions Testing with this user has a similar result: The administration sidebar menu shows links I don't have access to. On the other hand, I'm prevented from seeing the Administration home page altogether even though I should be able to reach Acquisitions preferences from there. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11130] Change pl Place-publication index for Marc21
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- I note than in UNIMARC pl Place-publication is on 210$a. There is Country-publication on UNIMARC 102$a. Should it be on 008/15-17 ? I see 044$a that could also fit. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3849] Descriptions of acquisition permissions are unclear
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75450|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 75473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75473&action=ed… Bug 3849: Improve descriptions of granular acquisition permissions The permissions for acquisitions were not very clearly described. This patch changes the descriptions in the include file (GUI) and in the default SQL. To test: - Go to any patron account in staff - Go to more > permissions - Verify that the meaning of each acquisition permission is clear from the description Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3849] Descriptions of acquisition permissions are unclear
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 22 May '18

22 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com --- Comment #12 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Josef Moravec from comment #10) > This is not the logged in user's home library, it is the library where the > user is logged in now - so when user change library, he/she could change > another's library rules! I (In reply to Katrin Fischer from comment #11) > But couldn't they change the home library in their records too? > I think in general we got a problem there, that you can get around the > limits, maybe the logged-in library is more helpful? I think this should be the user's logged in library - for extra protection I think the library would implement AutoLocation and limit logged in site by ip so this would require some extra steps but would also be a first level guard against accidentally altering other rules -- You are receiving this mail because: You are watching all bug changes.

1 0