June 2018 - Koha-bugs - lists.koha-community.org

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '18

20 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '18

20 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #56 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Oups there is an obsolete : use C4::Branch in t/db_dependent/Circulation/CanBookBeIssued.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18268] New: Notices no longer sent; resending when Patron Messaging Preference changed
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '18

20 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18268 Bug ID: 18268 Summary: Notices no longer sent; resending when Patron Messaging Preference changed Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: cgdavis(a)uintah.utah.gov QA Contact: testopia(a)bugs.koha-community.org A patron’s Koha account had a address within its primary email address field and all patron messaging preferences were enabled (including the “Digests only” preferences), and yet, after a time, Koha failed to send notices to the patron’s email address. It was confirmed when checking the “Notices sent for [patron name] ([patron barcode])” tab on the patron’s account that Koha stopped sending notices to the patron’s email address. The email addresses of another patron account with the same patron messaging preference within this Koha system received notices from Koha. Koha began re-sending notices to the patron email address when the “Item checkout” patron messaging preference was disabled and then re-enabled. This is on Koha 3.22.08 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 13680] Items list on edit items page separates add items form from header and sidebar
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Heather <heather_hernandez(a)nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez(a)nps.gov --- Comment #16 from Heather <heather_hernandez(a)nps.gov> --- I'm just looking at this for the first time, and I am a cataloger.:) I would love ANYTHING that gets me away from scrolling down through 200+ items to add an item!!! I can live with the modal--I often copy from an existing item in the table & paste into the new item, and with the model I'd simply do that from another browser tab, easy-peasy. My dream is that the "Actions" buttons (on the items in the item table) would have a "Duplicate" action that would allow me to clone an item that duplicated that item exactly except for $d and $p and I could then add a new barcode, edit the $h and/or $t and be done. Until then, this modal add item is a HUGE improvement. (Now, if I could get that "Duplicate" in the "Actions" button and launch that new item modal like this, I'd be living the dream!) I like the "View" button. I'm most often going directly from item editing to bib record editing (with Advanced Editor/Rancor), so don't mind one more click to get to "Normal." (I edit items first then go to Rancor because starting with Rancor then "Edit items" opens editing the items another tab, which I find annoying--I'd prefer it staying in the same tab.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19086] Multiple cross-site scripting vulnerabilities
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19086 --- Comment #45 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Interesting thing: on bug 13618 it was decided to not escape the patron's messages. So maybe this will be be considered as a bug by some libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 20963] New: Can check out not for loan items when temporarily overriding restriction
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20963 Bug ID: 20963 Summary: Can check out not for loan items when temporarily overriding restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If the user has a restriction (for example DISCHARGE) and you use the 'temporary override' button, it's possible to check out items with not for loan itemtypes. Even when AllowNotForLoanOverride is set to not allow override. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #79 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Some more QA comments, I have not checked if previous requests have been addressed. 1. Bug - add or edit a patron and add 2 fathers, one from an existing patron and the other not. Only 1 is saved. 2. On the edit patron view, the "Delete" checkbox does not have the correct label (i.e. when you click on it, it will not check/uncheck the checkbox). (related to comment 52, 2/) 3. a. It is not clear to me why you removed the contact* fields from the borrowers table. It looks like they were also used when no guarantor existed. b. Moreover `git grep contactfirstname|grep -v altcontactfirstname` returns occurrences that should be removed (if we really want to remove them) c. The fields are not removed from borrowermodification and deletedborrowers (from the atomic update) d. IMPORTANT - Should not we finally keep these fields and force the guarantors to be existing patrons? We could have only 1 "contact" and several guarantors. It seems that it will simplify a lot the code (for instance Koha::Patron->guarantors would return Koha::Patrons, and Koha::Patron::Relationship[s] would stay simple Koha::Object[s]) 4. Should not the table name "relationships" be more specific? ("borrower_relationships"?) 5. add_guarantors should be moved to Koha::Patron 6. Koha::Patron->siblings is weird, we should not need to refetch the patron list. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20947] New: Navigating to moremember.pl for a patron who has fines on deleted items causes software error.
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947 Bug ID: 20947 Summary: Navigating to moremember.pl for a patron who has fines on deleted items causes software error. Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Note this ONLY happens in 17.11 -- earlier versions of Koha don't have this code, and GetMemberAccountRecords does not exist in 18.05+ (per bug 12001)... however it is a major problem in 17.11. -- Steps to re-create: 1) Find a borrower with fines, preferably on an item that has already been checked in. 2) Delete the item 3) Navigate to moremember.pl for that borrower. This will trigger a software error with Can't call method "biblio" on an undefined value at /usr/share/koha/lib/C4/Members.pm line 767. in the plack-error.log Here's the code: 750 sub GetMemberAccountRecords { 751 my ($borrowernumber) = @_; 752 my $dbh = C4::Context->dbh; 753 my @acctlines; 754 my $numlines = 0; 755 my $strsth = qq( 756 SELECT * 757 FROM accountlines 758 WHERE borrowernumber=?); 759 $strsth.=" ORDER BY accountlines_id desc"; 760 my $sth= $dbh->prepare( $strsth ); 761 $sth->execute( $borrowernumber ); 762 763 my $total = 0; 764 while ( my $data = $sth->fetchrow_hashref ) { 765 if ( $data->{itemnumber} ) { 766 my $item = Koha::Items->find( $data->{itemnumber} ); 767 my $biblio = $item->biblio; The problem is that $data->{itemnumber}, (the itemnumber read from accountlines) may point to an active item or a deleted item. If the item was deleted, $item, as populated in my $item = Koha::Items->find( $data->{itemnumber} ); will be undef, and my $biblio = $item->biblio; Will throw the error message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr -- You are receiving this mail because: You are watching all bug changes.

1 0