June 2018 - Koha-bugs - lists.koha-community.org

[Bug 20963] New: Can check out not for loan items when temporarily overriding restriction
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20963 Bug ID: 20963 Summary: Can check out not for loan items when temporarily overriding restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If the user has a restriction (for example DISCHARGE) and you use the 'temporary override' button, it's possible to check out items with not for loan itemtypes. Even when AllowNotForLoanOverride is set to not allow override. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #79 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Some more QA comments, I have not checked if previous requests have been addressed. 1. Bug - add or edit a patron and add 2 fathers, one from an existing patron and the other not. Only 1 is saved. 2. On the edit patron view, the "Delete" checkbox does not have the correct label (i.e. when you click on it, it will not check/uncheck the checkbox). (related to comment 52, 2/) 3. a. It is not clear to me why you removed the contact* fields from the borrowers table. It looks like they were also used when no guarantor existed. b. Moreover `git grep contactfirstname|grep -v altcontactfirstname` returns occurrences that should be removed (if we really want to remove them) c. The fields are not removed from borrowermodification and deletedborrowers (from the atomic update) d. IMPORTANT - Should not we finally keep these fields and force the guarantors to be existing patrons? We could have only 1 "contact" and several guarantors. It seems that it will simplify a lot the code (for instance Koha::Patron->guarantors would return Koha::Patrons, and Koha::Patron::Relationship[s] would stay simple Koha::Object[s]) 4. Should not the table name "relationships" be more specific? ("borrower_relationships"?) 5. add_guarantors should be moved to Koha::Patron 6. Koha::Patron->siblings is weird, we should not need to refetch the patron list. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20947] New: Navigating to moremember.pl for a patron who has fines on deleted items causes software error.
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947 Bug ID: 20947 Summary: Navigating to moremember.pl for a patron who has fines on deleted items causes software error. Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Note this ONLY happens in 17.11 -- earlier versions of Koha don't have this code, and GetMemberAccountRecords does not exist in 18.05+ (per bug 12001)... however it is a major problem in 17.11. -- Steps to re-create: 1) Find a borrower with fines, preferably on an item that has already been checked in. 2) Delete the item 3) Navigate to moremember.pl for that borrower. This will trigger a software error with Can't call method "biblio" on an undefined value at /usr/share/koha/lib/C4/Members.pm line 767. in the plack-error.log Here's the code: 750 sub GetMemberAccountRecords { 751 my ($borrowernumber) = @_; 752 my $dbh = C4::Context->dbh; 753 my @acctlines; 754 my $numlines = 0; 755 my $strsth = qq( 756 SELECT * 757 FROM accountlines 758 WHERE borrowernumber=?); 759 $strsth.=" ORDER BY accountlines_id desc"; 760 my $sth= $dbh->prepare( $strsth ); 761 $sth->execute( $borrowernumber ); 762 763 my $total = 0; 764 while ( my $data = $sth->fetchrow_hashref ) { 765 if ( $data->{itemnumber} ) { 766 my $item = Koha::Items->find( $data->{itemnumber} ); 767 my $biblio = $item->biblio; The problem is that $data->{itemnumber}, (the itemnumber read from accountlines) may point to an active item or a deleted item. If the item was deleted, $item, as populated in my $item = Koha::Items->find( $data->{itemnumber} ); will be undef, and my $biblio = $item->biblio; Will throw the error message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #263 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- The whole set should apply atop master. I have two sets of customers currently testing and feeding back on it and hope to add them as signoffs once they're happy. But a further SO would be great if I can find someone to do it.. In the meantime I'd be interested in some QA/Const cutive Critisism on the Cron script as that was somewhat rush changed to try and make it for 18.05. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #262 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #260) > Fully rebased and taken account of a few pieces of customer feedback in the > followups. Do they test on top of master? Should not we add their signed-off-by lines? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #55 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Oups, looks like patch makes a lot of unwanted changes in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20964] New: search_patrons_to_anonymise selects different user than GetBorrowersWithIssuesHistoryOlderThan did.
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964 Bug ID: 20964 Summary: search_patrons_to_anonymise selects different user than GetBorrowersWithIssuesHistoryOlderThan did. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Bug 16966 sought to move the patron selection routines from GetBorrowersWithIssuesHistoryOlderThan in C4 to a dbic centric query in Koha::Patrons. However, in do so, the resultant query was changed in such a way that rather than filtering patrons to anonymise by their home branch you are actually filtering by patrons who have ever had an biblio issued to them from a particular branch. This is a surprising and unexpected change in functionality for users upgrading to 17.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '18

19 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #28 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Lucie Gay from comment #26) > the priority rule is applied except for the loan period, it's the one define > in the more permissive rule which is taken into account. Hello Lucie, What do you mean by "except for the loan period" ? -- You are receiving this mail because: You are watching all bug changes.

1 0