June 2018 - Koha-bugs - lists.koha-community.org

[Bug 20866] New: ArticleRequests.t fails on existing requests
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '18

13 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 Bug ID: 20866 Summary: ArticleRequests.t fails on existing requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Subtest search_limited fails. # Subtest: search_limited 1..4 ok 1 - Koha::ArticleRequests should return all article requests not ok 2 - Koha::ArticleRequests->search_limited should return all article requests for superlibrarian # Failed test 'Koha::ArticleRequests->search_limited should return all article requests for superlibrarian' # at t/db_dependent/ArticleRequests.t line 216. # got: '1' # expected: '3' ok 3 - Koha::ArticleRequests should return all article requests not ok 4 - Koha::ArticleRequests->search_limited should not return all article requests for restricted patron # Failed test 'Koha::ArticleRequests->search_limited should not return all article requests for restricted patron' # at t/db_dependent/ArticleRequests.t line 219. # got: '0' # expected: '2' # Looks like you failed 2 tests of 4. not ok 55 - search_limited Can be fixed by clearing the table at the start. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '18

13 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72548|0 |1 is obsolete| | Attachment #72549|0 |1 is obsolete| | Attachment #72550|0 |1 is obsolete| | Attachment #72551|0 |1 is obsolete| | --- Comment #48 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 76015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76015&action=ed… Bug 14272: Show single news item [alternative patch] This is a new patch for this bug that shows a single news item on the OPAC using Koha Objects (Koha::News). To test: 1) Go to Tools -> News on staff interface, make a news item to show on the OPAC 2) Go to OPAC 3) Notice news item shows and title cannot be clicked 4) Apply patch, refresh page 5) Notice title is now a link. Click title 6) Confirm breadcrumbs shows title of news item 7) Confirm RSS feed and OpacMainUserBlock are not visible 8) In the URL, change the news_id param to an ID that does not exist 9) Confirm that an appropriate error message shows Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '18

13 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '18

13 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20924 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 [Bug 20924] News content textarea not showing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '18

12 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #245 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 1. aqbasketgroups.closedate is set to NOW, maybe better to use basket.closedate (the latest)? 2. ->bookseller should be ->vendor (not blocker as we already have both in Koha::*...) 3. a. I would not "cache" ->baskets, we already deal with the context in Koha::Objects->search b. ->baskets_count - no need to have it, it should be replaced with baskets->count => Maybe you want to keep them for performance purpose, but is it really a performance improvement? 5. basketgroup.tt has a [% IF booksellerid %], it should not be useful now. We may want to display a friendly message if called without a [valid] id 6. basketgroups.tt should have JS at the bottom 7. Some links still point to basketgroup.pl?booksellerid=X without the basketgroupid, they should be replaced right? i.e. code related to 'sub displaybasketgroups' in basketgroup.pl should be removed (?) 8. Are you sure you need the changes done to C4::Acquisition? 9. acqui/basketgroup.pl + use List::MoreUtils qw/uniq/; => Not needed 10. "kohaDataTable": We already have KohaTable. You are adding a 3rd way to init a table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4078] Add the ability to customize and display the symbol for a currency
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '18

12 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20922 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Fix tax and prices calculation
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '18

12 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20922 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '18

12 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '18

12 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #124 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #113) > Bug 12395: Save order line's creator > reverts bug 20303 This one is still missing I think. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20914] New: Internal server error in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '18

12 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20914 Bug ID: 20914 Summary: Internal server error in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org opac-user.pl tries to fetch an invalid column when calculating fines. my $rental_fines = Koha::Account::Lines->search( { borrowernumber => $patron->borrowernumber, amountoutstanding => { '>' => 0 }, accounttype => 'Rent', itemnumber => $issue->{itemnumber} }, { select => [ { sum => 'amountoutstanding' } ], as => ['rental_fines'] } ); $issue->{rentalfines} = $charges->count ? $charges->next->get_column('rental_fines') : 0; This code fetches the column "rental_fines" into the variable "$rental_fines", but then tries to read that column data from a different variable ("$charges"). -- You are receiving this mail because: You are watching all bug changes.

1 1