June 2018 - Koha-bugs - lists.koha-community.org

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 75967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75967&action=ed… Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. To test, apply the patch and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13680] Items list on edit items page separates add items form from header and sidebar
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #14 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- I love it! I'm not a cataloger, but I think it is a MASSIVE improvement as a modal. I would definitely go that direction. I also like the changes with View. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #110 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Rebased and solved simple conflicts. (In reply to Marcel de Rooy from comment #97) > OK If you feel the name is good enough As most active people here have more experience with the code and the English language, I'll happily change to any suggestion. (even if I might ask for confirmation if I feel that it's not that clear or ambiguous ^^) > Just do not use formating, single t :) Fixed ^^ > > > So thousands separators come at the expense of handling both dots and commas. > > > Still opt for something that is more understandable. > > I'm not sure to understand. Is the the current state the patch on this topic > > acceptable? > Would it be clearer if you would say that you c/should not use characters > from the DecimalSeparator pref also as thousands separator? completed: What do you think of the current version? TODO wait answer, blocking question Does the followups require all the fields to be retested? And put back the patch to "Needs Signoff". TODO wait answer, blocking question > > When this bug and bug 18723[1] will be in master there won't be more > > fragmentation than today. > > And less actually. > > > > locally: acquisitions and payments/fines will be internally less fragmented. > > as there are currently different behaviors in *successive pages* [2] > > globally: the new approach replaces an existing one (I checked that it not > > used elsewhere) > > see moneyFormat function. > > > > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75127&action=di… > > > > So, are these changes a step in the right direct worth of begin integrated? > Well, I just hope so. But willing to follow your argument. Feel free to > submit the tiny adjustments you intend to, and I will try to finish here. Great, I think every feedback has been addressed if I'm not mistaken :) Thanks again for you time! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13680] Items list on edit items page separates add items form from header and sidebar
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #13 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 75965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75965&action=ed… Screenshot showing entry form in modal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13680] Items list on edit items page separates add items form from header and sidebar
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #12 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 75964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75964&action=ed… Screenshot showing views as dropdown menu -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75952|0 |1 is obsolete| | --- Comment #109 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 75959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75959&action=ed… Bug 12310: (follow-up) Complete DecimalSeparators syspref description -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #108 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 75958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75958&action=ed… Bug 12310: (QA follow-up) Fix typo: unformating → unformatting -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75950|0 |1 is obsolete| | --- Comment #107 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 75957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75957&action=ed… Bug 12310: (follow-up) Fix forgotten writeoff amount field This is a follow up for this forgotten field. See main patch more details. == Test plan == 1. Use a translation of the staff interface if possible. 2. Go to a patrons's page → fines → pay fines 3. Click on "Write off" This assumes an existing debt. Which should exists if you just tested the previous patches. 4. If you enter "1,50", the writeoff amount saved is only 1. This is the bug. 5. Apply this patch 6. run ~/src/installer/data/mysql/updatedatabase.pl 7. Refresh the page 8. Retry the write off. Apply the annex 1 to the "Writeoff amount" field 9. It works! \o/ === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" Same with "EUR 12.34" -> "12.34" 6. "EUR 12.34€thanks lyonthree" -> "12.34" 7. "123 456,7" -> "123456.7" 8.. "2" -> "2" 9.. "2,0" -> "2.0" 10. "-1'345.95" -> "-1345.95" 11. ",1234" -> ".1234" 12. Set DecimalSeparators syspref to "," 13. Reload the page with the form 14. "1.000" -> "1000" 15. "1.000.000,10" -> "1000000.10" 16. Set DecimalSeparators syspref to "." 17. Reload the page with the form 18. "1,000" -> "1000" 19. "1,000,000.10" -> "1000000.10" 20. Validate the form and check that the final value with the dot was 21 well handled. 22. Think about Koalas and smile. 🐨🐨🐨 Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0