June 2018 - Koha-bugs - lists.koha-community.org

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #100 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 75949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75949&action=ed… Bug 12310: (QA follow-up) Prevent updatedatabase noise Added IGNORE into the SQL statement. TEST PLAN --------- run the atomic update multiple times. -- noise apply patch run the atomic update multiple times. -- no noise Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #99 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 75948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75948&action=ed… Bug 12310: (follow-up) Keep the example text in fines This puts the example text back in with the correct decimal separator. The example uses the first char of the syspref. TEST PLAN --------- 1) set the I18N/L10N DecimalSeparators syspref to "," 2) go to a patron's fines tab. 3) open Create manual invoice and Create manual credit tabs 4) check both tabs -- Example: 5.00 appears 5) apply this patch 6) reload the page and check both create tabs. -- Example: 5,12 appears 7) set the I18N/L10N DecimalSeparators syspref to ".," 8) go back and check both tabs. -- Example: 5.12 appears (only the first separator is picked) 9) optionnal: run koha qa test tools Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #98 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 75947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75947&action=ed… Bug 12310: Decimal separator issues: fixes in fines The main goal is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator Bonuses: - Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator. It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DecimalSeparators syspref. - minuses, doesn't remove them - non-decimal values: it doesn't touch them == Test plan == 1. Use a translation of the staff interface if possible. 2. When you pay an existing fine (more details in the next steps if needed). Check that you can't enter any string except like "XX.XX" (examples in Annex 1) without having an issue after validation. (x100, truncation, etc) 3. Apply this patch 4. run ~/src/installer/data/mysql/updatedatabase.pl 5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 6. Apply the annex 1 to the "Amount" field 7. When paying a fine (cgi-bin/koha/members/paycollect.pl) 8. Click on "Pay amount" to go to the page to pay all fines 9. Apply the annex 1 to the "Collect from patron" field 10. Click on "Pay" to go to the page to pay fine 11. Apply the annex 1 to the "Collect from patron" field 12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 13. Apply the annex 1 to the "Amount" field 14. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. (and prevent me from having bounty on my head) 15. Express your happiness. This is important, otherwise the sign off spell won't work! The details of expressing your happiness depend on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. What follows is just a list of examples. They don't have to be tried on each field. 6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" 7. Same with "EUR 12.34" -> "12.34" 8. "EUR 12.34€hi lyonthree" -> "12.34" 9. "123 456,7" -> "123456.7" 10. "2" -> "2" 11. "2,0" -> "2.0" 12. "-1'345.95" -> "-1345.95" 13. ",1234" -> ".1234" 14. Set DecimalSeparators syspref to "," 15. Reload the page with the form 16. "1.000" -> "1000" 17. "1.000.000,10" -> "1000000.10" 18. Set DecimalSeparators syspref to "." 19. Reload the page with the form 20. "1,000" -> "1000" 21. "1,000,000.10" -> "1000000.10" 22. Validate the form and check that the final value with the dot was well handled. 23. Think about Koalas and smile. 🐨🐨🐨 Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2426] Management permissions is deprecated
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Not pushing to 18.05.x as it could surprise unsuspecting librarians during a minor update having this permission disappear (even though it effectively does nothing at present). Nice fix for 18.11, marking resolved. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20546] New: Shelving location not displayed on checkin
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20546 Bug ID: 20546 Summary: Shelving location not displayed on checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: magnus(a)libriotech.no Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: - Make sure you have a couple of books with a value for shelving location (952$c) - Check the books out - Check the books in - Verify nothing is displayed in the "Shelving location" column on /cgi-bin/koha/circ/returns.pl Patch coming in a second. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #48 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #43) > QA Comment: > > Why do you add in catalogue/search.pl: > +use String::Random; > > +@results_per_page_options = do { my %seen; grep { !$seen{$_}++ } > @results_per_page_options }; > Could you 'do' this without a do statement? Do you need uniq from List::More > ? > Is it really needed btw? Do you expect duplicate numbers in this pref.. > This is now gone in latest follow-up. > results.tt > Why are you changing the lines with respect to list counts? What is the > relation with this patch? > This seems unrelated to this patch but is no longer affected in the follow-up. > opac-search.pl > -$offset = ($page-1)*$results_per_page if $page>1; > Why do you remove it ? > Offset is dealt with later. > - ($error, $results_hashref, $facets) = > C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers, > $results_per_page,$offset,$expanded_facet,undef,$query_type,$scan); > + ($error, $results_hashref, $facets) = > C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers, > $results_per_page,$offset,$expanded_facet,$query_type,$scan); > You remove a undef parameter. > Why? Is this a bug on its own? What is the relation with this report? > > Please clarify or adjust. Have put undef param back. Not sure why this was removed initially. Ready for testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #47 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75941&action=ed… Bug 14715: [FOLLOW-UP] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '18

11 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68327|0 |1 is obsolete| | --- Comment #46 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75940&action=ed… Bug 14715: [FOLLOW-UP] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol <simon.pouchol(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0