June 2018 - Koha-bugs - lists.koha-community.org

[Bug 20798] New: Client side validation for for fund selection prevents adding only some records to a basket
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Bug ID: 20798 Summary: Client side validation for for fund selection prevents adding only some records to a basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 19453 Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not. In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used. Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 [Bug 19453] Client side validation broken for "Fund" select -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 20426] New: Can't import all titles from a stage file with default values
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Bug ID: 20426 Summary: Can't import all titles from a stage file with default values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org When you import staged file for an order, you could have a lot of title in a file and you need to use default "item information" and default "Default accounting details" to choose budget and item informations. I try to import with this default information and I have an error message : 'Some budgets are not defined in item records' We use this every day in my university and we really need this. Sonia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 19453] New: Client side validation broken for "Fund" select
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 Bug ID: 19453 Summary: Client side validation broken for "Fund" select Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This might be a regression, or perhaps it has never worked, but the js-validation for the "Fund" select uses the selector [name="fund_code"] when the element is named "fund_id", correcting the selector fixes this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 20706] New: Fix links to help files for changed file structure (removed numbering on files)
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 Bug ID: 20706 Summary: Fix links to help files for changed file structure (removed numbering on files) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org With some clean-up done on the manual, we need to make sure the links to the manual still work alright: - remove the number part - check for links to systempreferences in help (now in their own chapter) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 39

[Bug 20763] New: AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 Bug ID: 20763 Summary: AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Some code executed in the script opac-suggestions.pl if the system preference AllowPurchaseSuggestionBranchChoice is enabled assumes there is a logged in user. If there is not, patrons will see the error "Internal Server Error". -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 20761] New: Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Bug ID: 20761 Summary: Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: nick(a)bywatersolutions.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl To recreate: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75862|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75863&action=ed… Bug 14866: [FOLLOW-UP] Make high holds work with different item types This patch fixes merge conflicts, fixes the indentation of the table in smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule. Keep in mind - I am sure that when the original patch for this was written (before get_effective_issuing_rule was used), it all worked fine. I had to add an extra line of code in my patch to get this method to work because it was fetching the WRONG circulation rule - one that did not have decreaseloanholds defined. I don't know if it was my patch that is broken or the get_effective_issuing_rule method that is not fetching the 'most specific/relevant' rule. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58324|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75862&action=ed… Bug 14866: Make high holds work with different item types This patch fixes merge conflicts, fixes the indentation of the table in smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule. Keep in mind - I am sure that when the original patch for this was written (before get_effective_issuing_rule was used), it all worked fine. I had to add an extra line of code in my patch to get this method to work because it was fetching the WRONG circulation rule - one that did not have decreaseloanholds defined. I don't know if it was my patch that is broken or the get_effective_issuing_rule method that is not fetching the 'most specific/relevant' rule. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42751|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 75861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75861&action=ed… Bug 14866: Make high holds work with different item types This patch adds the possibility to set decreased loan periods for high holds items in issuingrules via smart-rules.pl. If a rule exist with a value set for a high holds item and the decreaseLoanHighHolds syspref is active then the value of the rule will be used instead of the syspref value. To test: 1. Create testbranch, dump mysql as needed.. 2. Apply patch 3. Update database perl installer/data/mysql/updatedatabase.pl misc/devel/update_dbix_class_files.pl --db_name=koha_instance --db_user=koha_instance --db_passwd=thepassword 4. Enable decreaseLoanHighHolds sysprefs if not already active 5. Create rule for library/item in http://your_staff_client/cgi-bin/koha/admin/smart-rules.pl Set Decrease loan holds to your wanted value. 6. Check out an item with holds and see that the value from the rule is used instead of the syspref -- You are receiving this mail because: You are watching all bug changes.

1 0