July 2018 - Koha-bugs - lists.koha-community.org

[Bug 1807] search () give odd results
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21081] New: There is no check that patron is guarantor when batch deleting
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21081 Bug ID: 21081 Summary: There is no check that patron is guarantor when batch deleting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: sophie.meynieux(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When deleting one patron (members/deletemem.pl), Koha checks that patron is not a guarantor, else it does not allow deletion. But in tools > batch patron deletion (tools/borrowers.pl or misc/cronjobs/delete_patrons.pl), this check is not performed, so there is a lot of borrowers with guarantorid that does not exist any more. Check if patron is a guarantor should be performed in all cases of deletion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Conflicts with bug 20805 fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77052&action=ed… Bug 12159: (QA follow-up) Silencing POD warn from qa tools *** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77051&action=ed… Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76945|0 |1 is obsolete| | Attachment #76946|0 |1 is obsolete| | Attachment #76947|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77050&action=ed… Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #20 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Fridolin SOMERS from comment #19) > If back-port is possible, please provide a rebased patch. The patch would have to be largely re-written, so I'm inclined to let it go unless someone wants to twist my arm. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #96 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #79) > Some more QA comments, I have not checked if previous requests have been > addressed. > > 1. Bug - add or edit a patron and add 2 fathers, one from an existing patron > and the other not. Only 1 is saved. Fixed in followup. > 2. On the edit patron view, the "Delete" checkbox does not have the correct > label (i.e. when you click on it, it will not check/uncheck the checkbox). > (related to comment 52, 2/) Fixed in followup. > 3. > a. It is not clear to me why you removed the contact* fields from the > borrowers table. It looks like they were also used when no guarantor existed. > b. Moreover `git grep contactfirstname|grep -v altcontactfirstname` returns > occurrences that should be removed (if we really want to remove them) > c. The fields are not removed from and deletedborrowers > (from the atomic update) > > d. IMPORTANT - Should not we finally keep these fields and force the > guarantors to be existing patrons? We could have only 1 "contact" and > several guarantors. It seems that it will simplify a lot the code (for > instance Koha::Patron->guarantors would return Koha::Patrons, and > Koha::Patron::Relationship[s] would stay simple Koha::Object[s]) I'm going to have to ruminate on this and find out what the sponsors requirements are. I like how it would simplify the code, but it would also provide limitations that have already been overcome in the current patch set. > 4. Should not the table name "relationships" be more specific? > ("borrower_relationships"?) Done in followup > 5. add_guarantors should be moved to Koha::Patron Done in followup > 6. Koha::Patron->siblings is weird, we should not need to refetch the patron > list. I have no idea how to accomplish that. As far as I know there is no way to merge two dbic resultsets. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #95 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77049&action=ed… Bug 14570 [QA Followup]: Don't remove existing columns for the time being, pending review of request 3 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #94 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77048&action=ed… Bug 14570 [QA Followup]: change instance of param to multi_param -- You are receiving this mail because: You are watching all bug changes.

1 0