July 2018 - Koha-bugs - lists.koha-community.org

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66250|0 |1 is obsolete| | --- Comment #29 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77028&action=ed… Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66249|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77027&action=ed… Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66248|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77026&action=ed… Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66247|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77025&action=ed… Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7154] Group borrower attributes and link between patron category and attribute
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 [Bug 21080] patron attribute classes break patron's edit view -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #31 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I feel like Chris makes some valid points here when he says there is no proof that the additional changes are needed. We have tested this patch and found it to fix the problem we had reported. Patron images don't longer overlay and repeat. If we change the code further - what is the bug it fixes? What should be in the test plan? >FTR: I have no problem undefing the entire $image_data reference. As soon as I >have time, I will submit a follow-up patch. I also inadvertently removed the >statements which short-circuit the loop in the case of no image data. That needs >to be corrected as well. Does this mean the patch should not be used as is? Could the additional requested changes moved to another bug report for attending to them later? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9296] overduerules table needs restructuring to allow future extension
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin(a)inlibro.com |koha-bugs(a)lists.koha-commun | |ity.org --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx for the reply Philippe. Resetting assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10442] Remove references to non-standard "error" class
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72785|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 77022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77022&action=ed… Bug 10442: Remove references to non-standard "error" class The CSS for <div class="error"> is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard <div class="dialog alert">. To test: - In Acquisitions -> Late orders, locate an order from a vendor which doesn't have an email address. Selecting that order and clicking "Claim" should trigger an error dialog, "This vendor has no email." It should be styled correctly. - With AcqCreateItem set to "when placing an order," add to an existing order using the "From a new (empty) record" option. Add two items with identical barcodes and submit the form. A error should show at the top of the page. - With AcqCreateItem set to "when receiving an order," receive an order and add two items with identical barcodes. Submitting the form should trigger an error message at the top of the page. With the remaining cases I don't know how to trigger the errors in question, so a visual check of the changes may be required: - Administration -> Funds -> "You are not authorized to modify this fund" - Administration -> Search engine configuration (/admin/searchengine/elasticsearch/mappgings.pl) -> Various modification errors. - With the AutoEmailOpacUser preference set to "send," adding a patron without an email address can trigger an error, "This member has no email." - With plugins enabled, and installed, there are error messages displayed under various circumstances. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10442] Remove references to non-standard "error" class
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '18

17 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20714] New: Bug1
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20714 Bug ID: 20714 Summary: Bug1 Change sponsored?: --- Product: Koha Version: 17.11 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: ravindusaluwadana348(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3