July 2018 - Koha-bugs - lists.koha-community.org

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Pushing this back into the QA queue (for discussion between QA and developer we usually don't use "In Discussion" - only when you can't agree) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #47) > Please add unit tests Switching to NSO, I'd like a confirmation that the code is doing what we are expecting it to do. Then I will try to provide tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #22 from Chris Nighswonger <cnighswonger(a)foundations.edu> --- (In reply to Marcel de Rooy from comment #19) > Chris: > I have the impression Just an impression? ;-) Did you test and find a case where this fix does not work? that you are clearing the wrong variables at the end > of the for loop. You undef image, alt_image and binary_data. These three > vars are all created in the for loop. I guess they should not present a > problem? But $image_data is created outside the loop and is not cleared. > Isn't that the cause of the issue? I don't think so. > > Look at > my $binary_data = $image_data->{'imagefile'} > > Since $image_data is not cleared, bad things may still happen?? $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is a reference to a hash created by DBI containing the results of the SELECT. DBI creates a new hash on every row retrieval[1], ensuring that the data contained at our reference is fresh every time. Image::Magick, on the other hand, does not automatically "destroy" the original structure on each call, and so we need to take care of that.[2] [1] "By default a reference to a new hash is returned for each row." https://metacpan.org/pod/DBI#fetchrow_hashref [2] "Once you are finished with a PerlMagick object you should consider destroying it." http://www.graphicsmagick.org/perl.html -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger <cnighswonger(a)foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #21 from Chris Nighswonger <cnighswonger(a)foundations.edu> --- Changing status to more accurately reflect the current discussion. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #117 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- In HEA I've added the sysprefs next to other i18n ones. And added CurrencyFormat as it's somewhat linked with the one introduced by this patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Chris Nighswonger from comment #17) > Some kind soul please correct the spelling of "relegated" on line 180 during > QA! Your kind soul? :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Chris: I have the impression that you are clearing the wrong variables at the end of the for loop. You undef image, alt_image and binary_data. These three vars are all created in the for loop. I guess they should not present a problem? But $image_data is created outside the loop and is not cleared. Isn't that the cause of the issue? Look at my $binary_data = $image_data->{'imagefile'} Since $image_data is not cleared, bad things may still happen?? Changing status for feedback. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #116 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 76933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76933&action=ed… Bug 12310: (follow-up) Add relevant sysprefs to HEA DecimalSeparators: the new one CurrencyFormat: related because it's the display format -- You are receiving this mail because: You are watching all bug changes.

1 0