July 2018 - Koha-bugs - lists.koha-community.org

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76947&action=ed… Bug 12159: (QA follow-up) Silencing POD warn from qa tools *** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76946&action=ed… Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75811|0 |1 is obsolete| | Attachment #75812|0 |1 is obsolete| | Attachment #75822|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76945&action=ed… Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6647] Label item search should use standard pagination routine
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick(a)bywatersolutions.com --- Comment #5 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Pushing this back into the QA queue (for discussion between QA and developer we usually don't use "In Discussion" - only when you can't agree) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #47) > Please add unit tests Switching to NSO, I'd like a confirmation that the code is doing what we are expecting it to do. Then I will try to provide tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #22 from Chris Nighswonger <cnighswonger(a)foundations.edu> --- (In reply to Marcel de Rooy from comment #19) > Chris: > I have the impression Just an impression? ;-) Did you test and find a case where this fix does not work? that you are clearing the wrong variables at the end > of the for loop. You undef image, alt_image and binary_data. These three > vars are all created in the for loop. I guess they should not present a > problem? But $image_data is created outside the loop and is not cleared. > Isn't that the cause of the issue? I don't think so. > > Look at > my $binary_data = $image_data->{'imagefile'} > > Since $image_data is not cleared, bad things may still happen?? $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is a reference to a hash created by DBI containing the results of the SELECT. DBI creates a new hash on every row retrieval[1], ensuring that the data contained at our reference is fresh every time. Image::Magick, on the other hand, does not automatically "destroy" the original structure on each call, and so we need to take care of that.[2] [1] "By default a reference to a new hash is returned for each row." https://metacpan.org/pod/DBI#fetchrow_hashref [2] "Once you are finished with a PerlMagick object you should consider destroying it." http://www.graphicsmagick.org/perl.html -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '18

13 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger <cnighswonger(a)foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #21 from Chris Nighswonger <cnighswonger(a)foundations.edu> --- Changing status to more accurately reflect the current discussion. -- You are receiving this mail because: You are watching all bug changes.

1 0