July 2018 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079 [Bug 21079] Unify metadata schema across backends -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18851] New: use Test::DBIx::Class in 00-load.t breaks packaging
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Bug ID: 18851 Summary: use Test::DBIx::Class in 00-load.t breaks packaging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org Bug 18266 introduces a regression for a problem fixed in Bug 15150. Test::DBIx::Class is not mandatory because it is not available in Debian, packaging of Koha is broken because of the use in t/00-load.t. -- You are receiving this mail because: You are watching all bug changes.

1 44

[Bug 12772] Overdue Notice/Status triggers tool
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #28) > This is a privacy issue, I just didn't want it to die "in discussion". Yeah it is. No problem! Thx for following up.. Imo we are just clearing one variable away from PQA. I only need to convince Chris.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #28 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This is a privacy issue, I just didn't want it to die "in discussion". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #26) > I think setting back to SO after the dev has commented or provided a > follow-up is process-wise ok and standard - requires another check then by > QA. No problem. But normally this process between author and QAer does not need additional interfering. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think setting back to SO after the dev has commented or provided a follow-up is process-wise ok and standard - requires another check then by QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #23) > Pushing this back into the QA queue (for discussion between QA and developer > we usually don't use "In Discussion" - only when you can't agree) It is a FQA which I have set the last time. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Chris Nighswonger from comment #22) > (In reply to Marcel de Rooy from comment #19) > > Chris: > > I have the impression > > Just an impression? ;-) Did you test and find a case where this fix does not > work? Please keep in mind that we both have the same goal: fix bugs and improve code. QAing is more than testing. A careful look at the code can in my experience reveal bugs just as easy or show you what to test. > $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is > a reference to a hash created by DBI containing the results of the SELECT. > DBI creates a new hash on every row retrieval[1], ensuring that the data > contained at our reference is fresh every time. The crux is here indeed. This is only partially true. The code does only update $image_data in two of the if statement branches. So my observation and request is just to clear $image_data each time in the loop or put its definition into the loop. Clearing the other variables might be unneeded since they are created in the loop. So this reveals a test case: Make sure that record 1 in the loop is a patron image and record 2 comes in the eq 'none' branch. Record 2 will use the old value of $image_data. > Image::Magick, on the other hand, does not automatically "destroy" the > original structure on each call, and so we need to take care of that.[2] Fine with me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #30 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I believe Tomas is working on bug 20443.. which I think is the blocker here. -- You are receiving this mail because: You are watching all bug changes.

1 0