July 2018 - Koha-bugs - lists.koha-community.org

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #28 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This is a privacy issue, I just didn't want it to die "in discussion". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #26) > I think setting back to SO after the dev has commented or provided a > follow-up is process-wise ok and standard - requires another check then by > QA. No problem. But normally this process between author and QAer does not need additional interfering. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think setting back to SO after the dev has commented or provided a follow-up is process-wise ok and standard - requires another check then by QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #23) > Pushing this back into the QA queue (for discussion between QA and developer > we usually don't use "In Discussion" - only when you can't agree) It is a FQA which I have set the last time. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Chris Nighswonger from comment #22) > (In reply to Marcel de Rooy from comment #19) > > Chris: > > I have the impression > > Just an impression? ;-) Did you test and find a case where this fix does not > work? Please keep in mind that we both have the same goal: fix bugs and improve code. QAing is more than testing. A careful look at the code can in my experience reveal bugs just as easy or show you what to test. > $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is > a reference to a hash created by DBI containing the results of the SELECT. > DBI creates a new hash on every row retrieval[1], ensuring that the data > contained at our reference is fresh every time. The crux is here indeed. This is only partially true. The code does only update $image_data in two of the if statement branches. So my observation and request is just to clear $image_data each time in the loop or put its definition into the loop. Clearing the other variables might be unneeded since they are created in the loop. So this reveals a test case: Make sure that record 1 in the loop is a patron image and record 2 comes in the eq 'none' branch. Record 2 will use the old value of $image_data. > Image::Magick, on the other hand, does not automatically "destroy" the > original structure on each call, and so we need to take care of that.[2] Fine with me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #30 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I believe Tomas is working on bug 20443.. which I think is the blocker here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '18

15 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6647] Label item search should use standard pagination routine
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '18

15 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 19509] New: Show checkout status in item search result list
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '18

15 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19509 Bug ID: 19509 Summary: Show checkout status in item search result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl It would be nice if you could see if an item is checked out in the result list of the item search. A separate enhancement could be to also provide a search option on the checked out status. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 6828] Add admin dashboard for staff users
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '18

15 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- First problem here was that there was a set of old patches not obsoleted. So the conflict was inevitable. I've fixed this, but the other patches still don't apply. @Cab - you are correct, because of the cronjob and XML file needed this is not testable by a sandbox. Generally if you are looking for some easier ones, we have a keyword "Academy" on bugzilla, that we use to mark them. If there are none, feel free to bug me and I am happy to take a look at the queue with you. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0