July 2018 - Koha-bugs - lists.koha-community.org

[Bug 11983] code to select patrons to purge needs to be centralized
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I prefer the second approach even if more verbose. It's easier to read and to test. It will certainly be easier to maintain and less error prone. Few remarks: - The having could be replaced with a join, and so more efficient. - filter_by_last_issued sounds wrong. I agree we should have a pattern (here "filter_by_") to explicitly tell what we are doing, but it should also be meaningful. Maybe it is for native English speakers ;) - filter_by_has_issues($options) is not enough explicit IMO. Moreover $options is a boolean, and "issue" must be "checkout". I would suggest: $patrons->filter_by_has_pending_checkouts and another one (?) But maybe I am making things more complicated here. (note: it seems that this subroutine will not be used by cleanborrowers.pl, we do not have this use case) - Should not filter_by_has_issues be filter_by_have_issues? - filter_by_when_expired - the interface allows to filter by "expired before", now we provide a "and/or expire after", but it is not used. It means more code, more tests and so... more potential bugs. It is not a big deal for this one, but we could have filter_by_expired_before that will be easier to read/write/test. Not blocker but worth mentioning/discussing it I think. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21062] New: Clean up borrower_password_recovery when patron is deleted
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21062 Bug ID: 21062 Summary: Clean up borrower_password_recovery when patron is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When a patron is deleted, any entries in borrower_password_recovery should be deleted as well by cascade. CREATE TABLE `borrower_password_recovery` ( `borrowernumber` int(11) NOT NULL, `uuid` varchar(128) COLLATE utf8_unicode_ci NOT NULL, `valid_until` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, PRIMARY KEY (`borrowernumber`), KEY `borrowernumber` (`borrowernumber`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 20977] New: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Bug ID: 20977 Summary: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The naming mismatch can cause javascript errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 19990] New: opac/opac-discharge.pl has a FIXME that can be fixed
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Bug ID: 19990 Summary: opac/opac-discharge.pl has a FIXME that can be fixed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The variable $available is unnecessary and can be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #48 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Ready for testing. Use Test Plan in Comment 44 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73129|0 |1 is obsolete| | --- Comment #47 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 76859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76859&action=ed… Bug 8630: Regenerated minified OPAC CSS Regenerated minified OPAC CSS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #46 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 76853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76853&action=ed… Bug 8630: [FOLLOW-UP] Make Adlibris cover show on OPAC overdues tab and fix alignment of cover on Staff detail page. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73128|0 |1 is obsolete| | --- Comment #45 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 76852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76852&action=ed… Bug 8630 - Adlibris covers (OPAC less changes) This patch adds two new CSS classes specific to Adlibris covers. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73127|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 76851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76851&action=ed… Bug 8630 - Adlibris covers (OPAC templates) Changes to OPAC templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test opac-results.tt * Search library catalog from OPAC for "1984". * You should be sent to: http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=1984 * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * Test opac-detail.tt (continued from previous test's location) * Click on the title with cover (1984, ISBN: 9780451524935) * Cover should be displayed to the left in full size. * If clicked, should link to the full-size image. Test opac-results-grouped.tt * This template is only used if an external "grouping" server is setup and the syspref "OPACGroupResults" is set to "Use". * Personally I did not test this, b/c: terminally lazy * Test opac-showreviews.tt * Could not find any links to this location, manually enter it: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl * Image should be shown to the right in full size. * If clicked it should take you to the detail view with the comments tab opened. * Test opac-showreviews-rss.tt * Click on the RSS icon from previous test's start location. URL should be: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl?format=rss * An image tag linking to the full-size image without any styling class should be present. * Test opac-user.tt * Click on your username to open: http://127.0.1.1/cgi-bin/koha/opac-user.pl * Covers should be shown for checked out items with CSS class: adlibris-cover * When clicked the destination should be the same as clicking the title column entry: opac-details.pl * Test opac-opensearch.tt * Click on "Advanced search" and enter "1984" then press "Search" * This search screen uses a different template. * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * If clicked, should link to the OPAC detail view. * Test opac-readingrecord.tt * Click on your logged-in name to go to your personal page. * Click on "Your reading history" tab on the left. http://127.0.1.1/cgi-bin/koha/opac-readingrecord.pl * Covers should be shown in leftmost column with CSS class: adlibris-cover * If clicked, should link to the same as the 'Title' link. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0