August 2018 - Koha-bugs - lists.koha-community.org

[Bug 5621] Enhanced Content Add Indian Amazon Association Tags
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '18

26 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5621 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Alias|K, Prasanth | --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Prasanth, this bug is about Google translation, please file a separate bug for the Amazon issue. Please also keep in mind that most developers working on Koha are getting paid for their work - so there is no guarantee someone will be spending time on it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #243 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #242) > Created attachment 78158 [details] [review] > Bug 13618: (follow-up) Manually replace missing .raw > > Must be |$raw, not |raw > > Error: > Template process failed: undef error - raw: filter not found at > /home/vagrant/kohaclone/C4/Templates.pm line 122 > > To recreate: > Add a new restriction and visit circulation.pl?borrowernumber=42 Followup pushed to master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #53 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Nick Clemens from comment #52) > Awesome work all! > > Pushed to master for 18.11 Pushed schema files as followup -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #75 from Nick Clemens <nick(a)bywatersolutions.com> --- In testing I set the users branch to 'no' for pickup_location I found the user could then not place any holds in the opac. I am wondering if the call to 'CanBookBeReserved' in opac-reserve.pl should include banchcode or not? It seems even if the pickup location is not allowed the borrower should be able to pickup holds elsewhere. Rebased and adjusted on top of 15524, please take a look as well and let me know if all makes sense. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #74 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78171&action=ed… Bug 7534: (RM follow-up) Fix tests and adjust after bug 15524 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #73 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78170&action=ed… Bug 7534: Disambiguate branchcode parameter, make it match between subroutines -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #72 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78169&action=ed… Bug 7534: Fix number of tests for Holds.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #71 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78168&action=ed… Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl To test: -1. Have access to your browser's developer tools in order to modify <select> dropdown values 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No". Remember the branchcode of this library! 3. Go place a hold in OPAC 4. See the provided "Pick up location" list 5. Observe the library that you configured is not present in the list 6. You should see another library selected by default. Right click that and in Firefox/Chrome click "Inspect element" 7. You should see a list of <option value="xxxx">blabla</option> elements 8. Double click between value (xxxx in above example) and replace the value with the branchcode you remember from step 2. 9. Place the hold 10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold was not successful. 11. Go back to place a hold and this time do not modify any values. 12. Observe that a hold is now placed. Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #70 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78167&action=ed… Bug 7534: Validate pickup location in CanBook/ItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. To test: 1. prove t/db_dependent/Holds.t Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #69 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78166&action=ed… Bug 7534: (QA-follow-up) Default pickup location to Yes when adding a new library To test: 1. Apply the patches before this one 2. Go to /cgi-bin/koha/admin/branches.pl 3. Press New library button 4. Scroll down the page and observe Pickup location defaults to No 5. Apply this patch 6. Go to /cgi-bin/koha/admin/branches.pl 7. Press New library button 8. Scroll down the page and observe Pickup location now defaults to Yes Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0