August 2018 - Koha-bugs - lists.koha-community.org

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #74 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78171&action=ed… Bug 7534: (RM follow-up) Fix tests and adjust after bug 15524 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #73 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78170&action=ed… Bug 7534: Disambiguate branchcode parameter, make it match between subroutines -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #72 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78169&action=ed… Bug 7534: Fix number of tests for Holds.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #71 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78168&action=ed… Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl To test: -1. Have access to your browser's developer tools in order to modify <select> dropdown values 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No". Remember the branchcode of this library! 3. Go place a hold in OPAC 4. See the provided "Pick up location" list 5. Observe the library that you configured is not present in the list 6. You should see another library selected by default. Right click that and in Firefox/Chrome click "Inspect element" 7. You should see a list of <option value="xxxx">blabla</option> elements 8. Double click between value (xxxx in above example) and replace the value with the branchcode you remember from step 2. 9. Place the hold 10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold was not successful. 11. Go back to place a hold and this time do not modify any values. 12. Observe that a hold is now placed. Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #70 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78167&action=ed… Bug 7534: Validate pickup location in CanBook/ItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. To test: 1. prove t/db_dependent/Holds.t Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #69 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78166&action=ed… Bug 7534: (QA-follow-up) Default pickup location to Yes when adding a new library To test: 1. Apply the patches before this one 2. Go to /cgi-bin/koha/admin/branches.pl 3. Press New library button 4. Scroll down the page and observe Pickup location defaults to No 5. Apply this patch 6. Go to /cgi-bin/koha/admin/branches.pl 7. Press New library button 8. Scroll down the page and observe Pickup location now defaults to Yes Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #68 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78165&action=ed… Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl This patch sets opac-reserve.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go to OPAC and place a hold 4. See the provided Pickup location list 5. Observe the library that you configured is not present in the list Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #67 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78164&action=ed… Bug 7534: Display pickup locations instead of all libraries in request.pl This patch sets request.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go place a hold in intranet 4. See the provided "Pickup at" list 5. Observe the library that you configured is not present in the list 6. Place the hold 7. See list of existing holds on that biblio 8. See "Pickup library" column and observe your configured library is not included in the list Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #66 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78163&action=ed… Bug 7534: Add configuration to admin/branches.pl This patch adds a configuration option for pickup locations. To test: 1. Apply patch 2. Go to cgi-bin/koha/admin/branches.pl 3. Observe there is a new column "Pickup location" 4. Click "Edit" for any library 5. Scroll to bottom of the page and select "No" 6. Click "Submit" 7. Observe your library in Libraries-table, notice the value of "Pickup location" has changed to "No" Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '18

25 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #65 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78162&action=ed… Bug 7534: Use search parameters for Koha::Template::Plugin::Branches->all This lets us query libraries with additional search parameters and is useful for this particular Bug by allowing us to select pickup locations. Unit tests included. To test: 1. prove t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0