August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '18

17 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6976] User hold limit can be avoided by users in OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '18

17 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Cheryl <clackman(a)fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman(a)fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '18

17 Aug '18

1 0

[Bug 14711] We do no longer need bibitems in AddReserve
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '18

17 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42198|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77940&action=ed… Bug 14711: Change prototype for AddReserve - pass a hashref The number of parameters of AddReserve makes it hard to read and maintain. This patch replace it with a hashref, which will make the calls more readable. Moreover the bibitems has been removed as it was not used by the subroutine. Test plan: - Make sure the tests pass - Read the diff and search for typos - Place a hold on few items Note for QA: reservation_date and expiration_date do not match the DB column's names, should we? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14711] We do no longer need bibitems in AddReserve
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '18

17 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14711] We do no longer need bibitems in AddReserve
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14711] We do no longer need bibitems in AddReserve
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |jonathan.druart(a)bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Josef Moravec from comment #17) > There is a cosmetic issue in form for searching > > https://screenshots.firefox.com/FNkRRFxBZKgIwDey/localhost > > but overall it looks good Hi Josef, thanks for testing! The misplaced issue you see is not related to this patch, see bug 21223. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14711] We do no longer need bibitems in AddReserve
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|j.kylmala(a)gmail.com |koha-bugs(a)lists.koha-commun | |ity.org CC| |joonas.kylmala(a)helsinki.fi --- Comment #5 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- I'm not working on this anymore, somebody else feel free to take this further. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec(a)gmail.com --- Comment #17 from Josef Moravec <josef.moravec(a)gmail.com> --- There is a cosmetic issue in form for searching https://screenshots.firefox.com/FNkRRFxBZKgIwDey/localhost but overall it looks good -- You are receiving this mail because: You are watching all bug changes.

1 0