August 2018 - Koha-bugs - lists.koha-community.org

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #22 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77899&action=ed… Bug 7614 - Fix my variable earlier declaration bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77898&action=ed… Bug 7614: Build a list of pickup locations in OPAC considering transfer limits This patch enables the checks for transfer limits for given biblionumber in OPAC when patron proceeds to place a hold. In case none of the items of that biblio can be transferred to a library, that library will not be included in the list of pickup locations. To test: 1. Make sure you meet the following requirements: 1.1: You are able to make holds in OPAC 1.2: System preference UseBranchTransferLimits set to "Enforce" 1.3: System preference BranchTransferLimitsType set to "item type" (for the sake of simplicity of this test plan, but you may also set it to "collection code" and deal with ccodes instead) 1.4: System preference item-level_itypes set to "specific item" 1.5: You have the default libraries and item types, otherwise replace the branchcodes and itemtypes in this test plan with your own 2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled its ability to act as a "Pickup location" 3. Have a biblio with exactly one item of item-level itemtype 'BK' 4. Set item holdingbranch as 'CPL' 5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in a second tab for faster testing) 6. Select library 'Centerville' 7. Uncheck the checkbox 'FFL - Fairfield' and click Save 8. Go to OPAC and find your biblio, and start placing a hold on it 9. Click at the list of "Pick up location"s. 10. Observe that it is missing 'Fairfield' 11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl 12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield' 13. Refresh the page you arrived at step 8 14. Observe that it now includes 'Fairfield' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77897&action=ed… Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches Consider transfer limits in Koha::Template::Plugin::Branches->pickup_locations. This patch modified the mentioned method to consider branch transfer limits and does not include any library in the returned list of libraries in case a branch transfer limit applies for a given book or item. To be tested in following patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #19 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77896&action=ed… Bug 7614: Check transfer limit in CanBookBeReserved and CanItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. This patch checks if the library is configured to be a pickup location (see Bug 7534), and also if the item can be transferred into the given library (see Bug 18072). To test: 1. prove t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60141|0 |1 is obsolete| | Attachment #60142|0 |1 is obsolete| | Attachment #60785|0 |1 is obsolete| | Attachment #60786|0 |1 is obsolete| | Attachment #60787|0 |1 is obsolete| | Attachment #60938|0 |1 is obsolete| | Attachment #60946|0 |1 is obsolete| | Attachment #70047|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77895&action=ed… Bug 7614: Add a new method Koha::Libraries->pickup_locations This patch adds a new method, Koha::Libraries->pickup_locations. This method takes either an item or a biblio as a parameter, and returns the list of acceptable pickup locations by considering libraries' configuration to act as a pickup location as well as any branch transfer limits that may apply. To test: 1. prove t/db_dependent/Koha/Libraries.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18236] New: Add classes to material type icons on result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Bug ID: 18236 Summary: Add classes to material type icons on result lists and detail pages Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Some libraries would prefer to show different material type icons in the result lists and detail pages in OPAC in staff. In order to make this possible with CSS, it would be nice if every icon had its own specific class so it's easy to target them. Something like: mt_icon_book, mt_icon_film, mt_icon_... -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 19743] New: Header and Footer should be updated on each item for checkin / checkout / renewal notices
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '18

16 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 Bug ID: 19743 Summary: Header and Footer should be updated on each item for checkin / checkout / renewal notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When generating the checkout notice for a patron we only update the section in between the '---' tags For template toolkit purposes it means we cannot affect the content based on more than a single item. For instance, we want to add the total cost of all items checked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '18

15 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #62 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77856&action=ed… Bug 7534: Disambiguate branchcode parameter, make it match between subroutines -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '18

15 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #61 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 77855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77855&action=ed… Bug 7534: Fix number of tests for Holds.t -- You are receiving this mail because: You are watching all bug changes.

1 0