August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77517&action=ed… Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77516&action=ed… Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77515&action=ed… Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77514&action=ed… Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77314|0 |1 is obsolete| | Attachment #77315|0 |1 is obsolete| | Attachment #77316|0 |1 is obsolete| | Attachment #77317|0 |1 is obsolete| | Attachment #77318|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77513&action=ed… Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21165] New: Notice Module governs fields available in letter.pl, but this often doesn't fit letter.code
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21165 Bug ID: 21165 Summary: Notice Module governs fields available in letter.pl, but this often doesn't fit letter.code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When or updating a new notice in Home › Tools › Notices & Slips › Modify notice, staff can click on fields in the field list, then click 'Insert' and the field will appear at the cursor position in the message body. So, for example, when editing the 'DUEDGST' notice, one can select 'items.biblionumber', then click insert, and the text <<items.biblionumber>> will appear in the body of the message. The problem is that the available fields are selected based on letter.module. In the case of 'DUEDGST', this will be circulation... and this does exactly the wrong thing, because most of the fields available (items.*, biblio.*, biblioitems.*, issue.s*) are *not* valid in DUEDGST -- only <<items.content>> <<count>> and branches.* are valid in that notice. Also, there are things missing that *could* be there -- for instance <<today>> and <<count>>. Also, if we're going to use loops like <items> </items> It should be possible to insert these from the list As it stands, the field list is often misleading. If 'DUEDGST' *only* showed <<items.content>>, it would easier for educators to point to the field list and as a reference. As it stands, at best, they have to qualify its usage, and at worst, the list is actively misleading. The list should probably be generated based on 'letter.code' -- the available codes are best read from the call to C4::Letters::GetPreparedLetter, especially the 'table' and 'repeat' hashrefs. Also, as we go forward using template toolkit based notices, it would be great if snippits of template toolkit code were available as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 18262] New: Koha::Biblios - Remove GetBiblioData - part 1
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Bug ID: 18262 Summary: Koha::Biblios - Remove GetBiblioData - part 1 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 32

[Bug 20667] New: Update two-column templates with Bootstrap grid: Acquisitions part 1
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Bug ID: 20667 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 14546, 20654 This patch will convert several acquisitions templates to use the Bootstrap grid: acqui/acqui-home.tt acqui/basketgroup.tt acqui/booksellers.tt acqui/edifactmsgs.tt acqui/edimsg.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77491&action=ed… Bug 14662: Add empty entries to pull downs in cataloguing form for mandatory subfields First patch deals with the problem on the item form, this patch fixes the same problem on catalouging form for the bibliographic record. To test: - Adapt your frameworks: - Make sure 942$c is mandatory - Link another field to an authorised value, for example: 942$n to YESNO - Add a new record - Verify that the first value of each pull down is preselected, there is no way to trigger the 'required' error - Apply patch - Add a record - Verify that classification source is preselected according to the DefaultClassificationSource system preference - Verify that 942$c now defaults to empty - Verify all your other mandatory subfields can be set to empty - Verify that you can't save before correctly setting them - Chane your frameworks - Add a default value for 942$c, for example: CF - Add another record - Verify the itemtype is now preset to your default itemtype - Edit an existing record, verify all values show correctly Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '18

06 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77443|0 |1 is obsolete| | Attachment #77445|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77490&action=ed… Bug 14662: Add empty entries to pull downs on item form for mandatory subfields The code assumed that if a subfield is marked as mandatory, there should be no empty entry in the pull downs. This assumption is not correct, as it leads to the first entry of the pull down being preselected if there is no default set. Which means you will never be alerted of any cataloguing errors and errors will be very hard to find later on. Correct behaviour would be to preselect the empty value when there is no default. This means on saving the item an error message is triggered and the cataloger is forced to set the value. To test: - Adapt your frameworks: - Make 942$c non-mandatory - In 952 make itemtype, classification source and some other pull downs like location or collection mandatory - Add a new item - Verify that the first value of each pull down is preselected, there is no way to trigger the 'required' error - Apply patch - Add a new item - Verify that classification source is preselected according to the DefaultClassificationSource system preference - Verify that the itemtype is preselected according to 942$c in the bibliographic record - Verify all mandatory fields can be set to empty - Verify that you can't save before correctly setting them - Change the 942$c in the record to empty - Add another item - Verify the itemtype is now empty - Change your frameworks and set a default for itemtype (Ex: BK) - Repeat default check with another pull down like collection or location Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> We do not want empty values for branches (holdingbranch and homebranch must be mandatory, see bug 21011) -- You are receiving this mail because: You are watching all bug changes.

1 0