August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #94 from Julian Maurice <julian.maurice(a)biblibre.com> --- To ease testing I squashed all the patches, merged the test plans, and removed the JS part (I will re-add it in another bug). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #93 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 77476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77476&action=ed… Bug 15395: Example usage of I18N Template::Toolkit plugin Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73901|0 |1 is obsolete| | Attachment #73902|0 |1 is obsolete| | Attachment #73903|0 |1 is obsolete| | Attachment #73904|0 |1 is obsolete| | Attachment #73905|0 |1 is obsolete| | Attachment #73906|0 |1 is obsolete| | Attachment #73907|0 |1 is obsolete| | Attachment #73908|0 |1 is obsolete| | Attachment #73909|0 |1 is obsolete| | Attachment #73910|0 |1 is obsolete| | Attachment #73911|0 |1 is obsolete| | Attachment #73912|0 |1 is obsolete| | Attachment #73913|0 |1 is obsolete| | Attachment #76328|0 |1 is obsolete| | Attachment #76329|0 |1 is obsolete| | Attachment #76330|0 |1 is obsolete| | --- Comment #92 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 77475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77475&action=ed… Bug 15395: Allow correct handling of plural translation Locale::Maketext does not allow correct handling of plural translation for languages that have more than one plural forms. Locale::Messages does. So Koha::I18N is now a wrapper around Locale::Messages, just like Locale::TextDomain, and export the same symbols as Locale::TextDomain. You can refer to documentation of Locale::TextDomain to know how to use exported subroutines. Example usage: __("Hi") __x("Hi {name}", name => 'Bob') __n("item", "items", $num_items) __nx("one item", "{count} items", $num_items, count => $num_items) __p("Bibliographic record", "item") This patch also brings Koha::I18N power to Template::Toolkit templates by adding a TT plugin. This plugin can be used like this: [%# USE the plugin and define some macros %] [% PROCESS 'i18n.inc' %] [%# tn is the equivalent of __n %] [%# macro names can't start with underscore, t is for "translate" %] [% tn('item', 'items', num_items) %] Extraction of strings from templates is a bit complicated and use Template::Parser and PPI. Template is compiled into Perl code and then analyzed by PPI. It is slow, but should be correct even with complex constructions. Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon Add dependency to Locale::Messages and PPI Test plan for translation in Perl code: 1. Open a .pl script or .pm module with your favorite text editor 2. Add 'use Koha::I18N;' in the beginning of file 3. Use one of the subroutines exported by Koha::I18N and be sure to have a way to visualize the result (pass result to the template for example, or simply warn and watch the log file) 4. cd misc/translator && ./translate update fr-FR # try other languages 5. Open misc/translator/po/fr-FR-messages.po and translate your string(s) You may need to change the "Plural-Forms" header. See https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct 8. prove t/Koha/I18N.t Test plan for translation in templates: 1. Open a template file (.tt or .inc) with your favorite text editor 2. Add the PROCESS directive mentioned above in the beginning of file 3. Use one of the t* macros defined in i18n.inc. They are used like their "__" equivalent, with one difference: the 'x' variants take a hashref instead of a hash as last parameter 4. cd misc/translator && ./translate update fr-FR 5. Open misc/translator/po/fr-FR-messages.po and translate your string(s) 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13692] series link is taking you to just 800a instead of whole 800
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 77474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77474&action=ed… Bug 13692: series link is taking you to just 800a instead of whole 800 This patch modifies the OPAC and staff client's XSL template for the detail page so that series links based on a traced 490 tag use both author and series title from the 800 tag. To test you should have multiple titles in the same series with matching 490 and 800 tags in each record. Apply the patch and restart Plack if necessary. View the detail page for one of the series' titles. The "Series:" link should link to a search which uses both series title and author. Clicking the link should return the correct results. Test both the OPAC and staff client. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13692] series link is taking you to just 800a instead of whole 800
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13692] series link is taking you to just 800a instead of whole 800
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21136] New: Error "No property select_city for Koha::Patron" when saving patron record
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21136 Bug ID: 21136 Summary: Error "No property select_city for Koha::Patron" when saving patron record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When I edit an existing patron in master, I get an error upon saving: No property select_city for Koha::Patron at /usr/share/perl5/Exception/Class/Base.pm line 73 To reproduce this error you must have cities defined in Administration -> Cities & towns. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 21129] New: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Bug ID: 21129 Summary: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: philippe.blouin(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org Bug 17234 made an effort to remove the ALTER IGNORE from updatedatabase.pl so that it could work with Mysql 5.7. But new entries have since been added to it: Bug 12395 - 18.06.00.005 Bug 19524 - 18.06.00.006 Bug 13560 - 18.06.00.008 These were oversights and must be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '18

03 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0