September 2018 - Koha-bugs - lists.koha-community.org

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '18

28 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 79557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79557&action=ed… Bug 14391: (QA follow-up) Resolve POD warn on svc..systempreferences *** WARNING: No items in =over (at line 48) / =back list at line 54 in file svc/config/systempreferences *** WARNING: No items in =over (at line 73) / =back list at line 79 in file svc/config/systempreferences => If you use 'over', you should add 'item'-s. Test plan: Run perldoc svc/config/systempreferences Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '18

28 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77538|0 |1 is obsolete| | Attachment #78109|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 79556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79556&action=ed… Bug 14391: Add granular permissions to the administration module So far the administration module only allowed for 2 permissions: - circulation conditions (manage_circ_rules) - everything else (parameters_remaining_permissions) With this patch almost every section of the administration page will have its own granular permission. To test: - Create different staff users: 1) One with parameters_remaining_permissions 2) One with parameters 3) One with catalogue and no parameters 4) One superlibrarian - Apply the patch - Run the database update - Check the staff users: 1) All subpermissions, but manage_circ_rules should be checked 2) Nothing should have changed 3) manage_item_serach_fields shoudl be checked (page had catalogue permission before) 4) Nothing should have changed - Try different settings of the permissions and verify that - Administration page behaves correctly - Administration menu behaves correctly ! You shoudl only see what you have permission for https://bugs.koha-community.org/show_bug.cgi?id=14391 Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '18

28 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- > > manage_classifications No text on form? => typo CASE 'manage_classfications' > > Missing letter ! Fixed! > > Spelling Manage column configuation / SRU server confiugration / search > > enginge Fixed! > > installer/data/mysql/atomicupdate/bug14391_granular_admin_permissions.sql > > The atomic update queries could be further optimized. You add separate > > inserts for each permission with subqueries for borrowers. Easy to read, but > > more costly to run. > > Do you have figures about how long it takes on a larger patron table ? I think there will be a limited number of patrons to be updated even for big libraries as the number of staff should still be relatively small compared to the potential number of users. > > Why not something like: > > INSERT INTO user_permissions (borrowernumber, module_bit, code) > > SELECT borrowers.borrowernumber, permissions.module_bit, permissions.code > > FROM borrowers > > LEFT JOIN user_permissions USING (borrowernumber) > > LEFT JOIN permissions ON module_bit =3 AND code NOT IN ( * list existing > > permissions for admin * ) > > WHERE user_permissions.code='parameters_remaining_permissions' > > This replaces most separate inserts and uses joins instead of subqueries. Need to take another look here if you think it's really necessary. > > > > admin/localization.pl, svc/localization > > Need manage_itemtypes > > Understand why you do it, but it seems not logical in the long run. Better > > add a specific one. I'll add a separate permission in another follow-up. > > > > admin/printers.pl > > parameters => '*' > > Only case where we refer to *. Why not separate? The code is dead and unused - I have proposed removing it instead on bug 7651. As it's currently not used and not visible in the GUI, I would not like to expose it with a new permission. As it's non-functional there is also a super low risk of people breaking something there :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views.
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '18

28 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #31 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Worse. The serial is the host, the children are the articles. The issue level is missing. This is because of the structure in our union catalog, but also fits Koha's subscription management. So this feature would have to be at least optional, nicer if we could use it of course. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views.
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '18

28 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #30 from paxed <pasi.kallinen(a)joensuu.fi> --- (In reply to Katrin Fischer from comment #29) > I really like the idea of this, but it won't work for some of our libraries > with hundreds of analytics on serial records. Could we truncate the list at > some (configurable) point with a 'see more' link at the end? Your serial parts are component records? So there's a serial "host record", of which each published magazine (or whatever) is a child record? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '18

28 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #98 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 79545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79545 Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. Review of attachment 79545: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=112…) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +475,4 @@ > > =head2 LinkBibHeadingsToAuthorities > > + my $num_headings_changed, %results = LinkBibHeadingsToAuthorities($linker, $marc, $frameworkcode, [$allowrelink, $verbose]); This is getting too long, consider a parameter refactor. Please look at: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_sho… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10869] Can't delete order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '18

28 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #88 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, looking at this too, I think it needs a bit of a rewrite. We added the cancellation reasons since this was first written and the whole cancellation process is slightly different now (delete order should be cancel order). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10869] Can't delete order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '18

28 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Summary|can't delete order line if |Can't delete order line if |title deleted |title deleted -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Rebased! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77726|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 79552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79552&action=ed… Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format -- You are receiving this mail because: You are watching all bug changes.

1 0