September 2018 - Koha-bugs - lists.koha-community.org

[Bug 4209] Column and row names in Basket Details are misleading
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4209 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14081] price labels are not consistent in acq
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #58 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 79538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79538&action=ed… Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid. This includes also a new system preference called FineChange which enables or disables the feature. Test plan : - Apply patch. - Make sure FineChange is at ENABLE in System preferences > Patrons. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$) - Confirm that the change is correct (example : 5$ - 3$ = 2$) - Click the button confirm. - Confirm that the payment has been made. - Make sure FineChange is at DISABLE in System preferences > Patrons. - Select a patron with a fine and go to Fines > Pay fines. - Confirm that the input change is gone. - Choose an amount collected (exemple : 3$). - Click the button confirm. - Confirm that the payment has been made. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #57 from Blou <philippe.blouin(a)inlibro.com> --- I've asked Pierre-Marc to squash these, since the second patch is mostly useless, and the second one is mostly removing the first one's changes. I know how QA will appreciate looking at this, so he's going to do a new one that's easier to interpret (and will need sign off). My apologies to Michal who took the time already to sign it off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #56 from Michal Denar <black23(a)gmail.com> --- Created attachment 79530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79530&action=ed… Bug 11373: System preference added, dialog removed, disabled input added to show the change in the form. This patch removes the dialog because it was redundant with the form. As the numbers fields are formated when they are changed, it is convenient to calculate and show the change at the same time. When the change value cannot be calculated (amount collected < amount paid), its value is brought back to 0.00. This includes also a new system preference called FineChange which enables or disables the feature. Test plan : - Apply patch. - Make sure FineChange is at ENABLE in System preferences > Patrons. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$) - Confirm that the change is correct (example : 5$ - 3$ = 2$) - Click the button confirm. - Confirm that the payment has been made. - Make sure FineChange is at DISABLE in System preferences > Patrons. - Select a patron with a fine and go to Fines > Pay fines. - Confirm that the input change is gone. - Choose an amount collected (exemple : 3$). - Click the button confirm. - Confirm that the payment has been made. https://bugs.koha-community.org/show_bug.cgi?id=11373 Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '18

27 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79188|0 |1 is obsolete| | Attachment #79509|0 |1 is obsolete| | --- Comment #55 from Michal Denar <black23(a)gmail.com> --- Created attachment 79529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79529&action=ed… Bug 11373: Add a "cash register" feature to the fine payment form. Works as intended. Signed-off-by: Simon Pouchol <simon.pouchol(a)biblibre.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0