September 2018 - Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #64 from Michal Denar <black23(a)gmail.com> --- I tester bug, but I get error: Applying: Bug 12532 - Send emails to guarantee and guarantor Using index info to reconstruct a base tree... M Koha/Patron.pm M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: installer/data/mysql/atomicupdate/bug_12532-RedirectGuaranteeEmail_syspref.sql Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 12532 - Send emails to guarantee and guarantor Its on master? Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views.
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |joonas.kylmala(a)helsinki.fi --- Comment #28 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- I cannot test this: Using index info to reconstruct a base tree... M C4/Search.pm M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Auto-merging C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 11175: Show record component parts in the detail view The copy of the patch that failed is found in: .git/rebase-apply/patch Also would it be better to make adding Control-number-identifier to it's own patch and how is this handled with Elasticsearch now that it is also supported by koha? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17491] New: Allow Koha Plugins to inject HTML into arbitrary pages
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17491 Bug ID: 17491 Summary: Allow Koha Plugins to inject HTML into arbitrary pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org We should have a system such that Koha Plugins can inject HTML into a given script template. It would be nice if we could specify in a plugin methods with a naming scheme that tells Koha which page to put the html on ( e.g. html_staff_mainpage would inject html into the mainpage.pl template ). More detailed work such as putting it in the correct place could be handled by the js injection in bug 17490. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 17490] New: Allow Koha Plugins to inject JavaScript into pages
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17490 Bug ID: 17490 Summary: Allow Koha Plugins to inject JavaScript into pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org We should add a system to the plugins architecture to allow a plugin to inject Javascript into the staff and or catalog side of Koha. This would be nice than the current workaround of adding the javascript to the UserJS system preferences. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #251 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79404&action=ed… Bug 13618: (follow-up) Pass opacuser_js from plugins as raw We expect this field to contain script tags, html processing breaks them -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Colin Campbell <colin.campbell(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #51 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- The commit should describe what the feature does. 'cash register feature' is not enough as its is ambiguous as to what kind of functionality you are adding. It might be better to handle this in javascript, theres no need to send to the server for this calculation it could all be handled more efficiently in the browser -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #50 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- The bug description is really misleading.. this doesn't add a cash register/till at all, rather it's just a method of displaying change to give. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #72 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- > > Why only changes to the ...style-us and not the other templates? > > If I look at it chronologically, this patch was first submitted at a time > when no {de,fr} templates existed. Commits for these templates came in 2015 > and 2017, and I couldn't say when they were added to the master. It's no > excuse for not reworking the patch, if that's what QA needs, but at least > there's a rationale: it was rebased over and over without extending what had > been done. I see the follow-up doesn't contain changes to the other address format files still, could you please check? > > What has this to do with making it possible for adults to be guarantors? ;) > > That looks like a prime candidate for an optional patch, I concede. But some > of the 'extra' developments in this patch were naturally asked by our > clients when we offered linking adults to adults. I do think there are > merits to keeping these functionalities together (though perhaps not as far > as keeping the example you quoted). I understand that it happens, my main point is documentation. By slipping in features into bugs without documenting them at least in the commit message, they often get lost and end up undocumented, especially when they don't fit the bugs description which is often all people look at in release notes. I hope to see this signed off soon! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7907] PDF printing of lists
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7907 --- Comment #5 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Is this still a valid bug. I have a library that would like to see the ability to download lists as PDF- I can see the attachment 8956 but no comments on is this a desired look or something that was created? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7942] Allow modification of basket group pdf template
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '18

26 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7942 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0