September 2018 - Koha-bugs - lists.koha-community.org

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #78 from Bouzid Fergani <bouzid.fergani(a)inlibro.com> --- Created attachment 79387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79387&action=ed… Bug11299 - Fix problems when authority is not found and i want add it Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #77 from Bouzid Fergani <bouzid.fergani(a)inlibro.com> --- Created attachment 79386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79386&action=ed… Bug 11299 - QA fix Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani <bouzid.fergani(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67824|0 |1 is obsolete| | Attachment #67825|0 |1 is obsolete| | Attachment #67826|0 |1 is obsolete| | Attachment #67827|0 |1 is obsolete| | Attachment #67828|0 |1 is obsolete| | Attachment #67829|0 |1 is obsolete| | --- Comment #76 from Bouzid Fergani <bouzid.fergani(a)inlibro.com> --- Created attachment 79385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79385&action=ed… Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #48 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Pierre-Marc Thibault from comment #47) > (In reply to Josef Moravec from comment #45) > > The information on this page is duplicate: > > > > https://screenshots.firefox.com/o2GtPtGugLjtJSqq/localhost > > > > why do you even add the dialog? > > > > Also this could be enabled disabled, please add system preference for this. > > The dialog is here maybe to explain to the user why they are still on the > page, because otherwise they just see a slight different formatted form when > the change is not null. If the dialogue is not a matter but the duplication > is, removing the "Change to give back:" line could be an option. Yes, the duplication is problem for me, now it is a bit confusing. I think the form itself should not be there, only dialog with all the information and the amount to give back to patron should be emphasized. > What do you want to add to system preferences precisely? The whole feature > with the change? Is that what you mean by "this"? Yes, that's exactly what I mean, because this change the behavior of pay functionality. > > Thanks for replying. Not at all ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com --- Comment #47 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- (In reply to Josef Moravec from comment #45) > The information on this page is duplicate: > > https://screenshots.firefox.com/o2GtPtGugLjtJSqq/localhost > > why do you even add the dialog? > > Also this could be enabled disabled, please add system preference for this. The dialog is here maybe to explain to the user why they are still on the page, because otherwise they just see a slight different formatted form when the change is not null. If the dialogue is not a matter but the duplication is, removing the "Change to give back:" line could be an option. What do you want to add to system preferences precisely? The whole feature with the change? Is that what you mean by "this"? Thanks for replying. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11405] Inventory tool enhancements
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21408 [Bug 21408] Inventory - Warn of items possibly scanned out of order -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Alex Arnaud from comment #56) > But i don't understand why puting your code at line #113 should be a problem > if the test still pass. This is probably the clue. You should ;) My extra line should make the test fail since it does not reset back to original value (empty string instead of null). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|Patch doesn't apply |Needs Signoff --- Comment #101 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to David Gustafsson from comment #100) > (In reply to Tomás Cohen Arazi from comment #95) > > I think I might be repeating myself, probably on a different bug. But I > > think we should add both whitelisting and blacklisting 'MARC record overlay > > configurations', and then hook them into whatever place we want (i.e. for > > z39.50, for OAI harvsting, etc). It seems to me that we are duplicating > > efforts in some places, and solutions don't look generic enough. > > > > 'Protecting' is just a way to say you are blacklisting some fields on > > overlaying. > > Now rebased again, so should work with latest master. "Protecting" is > probably a little bit misleading to reflect what the patch currently does, > it has been largely refactored since the first version (which I did not > write). I have renamed it to MARC merge rules instead, since it is more of a > framework for auto-merging records according to a set or rules. I hadn't noticed that. We should change the bug name to reflect what this actually does. > My experience is that is is really tricky to get this right, and if trying to > fit it into another abstraction that might not be suited for this exact > purpose it could be more trouble than it's worth > (https://www.sandimetz.com/blog/2016/1/20/the-wrong-abstraction) While I agree with the assertion, I don't think it is the case. What I'm saying is that we could just add a boolean (whitelist/blacklist) to specify a different behaviour, using the same code and rules. That's something that would belong to a separate bug, of course. I just mentioned here because I thought 'Protect' could be avoided, which you already did :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #100 from David Gustafsson <glasklas(a)gmail.com> --- (In reply to Tomás Cohen Arazi from comment #95) > I think I might be repeating myself, probably on a different bug. But I > think we should add both whitelisting and blacklisting 'MARC record overlay > configurations', and then hook them into whatever place we want (i.e. for > z39.50, for OAI harvsting, etc). It seems to me that we are duplicating > efforts in some places, and solutions don't look generic enough. > > 'Protecting' is just a way to say you are blacklisting some fields on > overlaying. Now rebased again, so should work with latest master. "Protecting" is probably a little bit misleading to reflect what the patch currently does, it has been largely refactored since the first version (which I did not write). I have renamed it to MARC merge rules instead, since it is more of a framework for auto-merging records according to a set or rules. My experience is that is is really tricky to get this right, and if trying to fit it into another abstraction that might not be suited for this exact purpose it could be more trouble than it's worth (https://www.sandimetz.com/blog/2016/1/20/the-wrong-abstraction) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17137] New: Omnibus: Always use SSL when referencing external sources
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137 Bug ID: 17137 Summary: Omnibus: Always use SSL when referencing external sources Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Amazon, OpenLibrary, etc shoudl all use https if available as otherwise they create a mixed content error for sites using https. -- You are receiving this mail because: You are watching all bug changes.

1 14