September 2018 - Koha-bugs - lists.koha-community.org

[Bug 11405] Inventory tool enhancements
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21408 [Bug 21408] Inventory - Warn of items possibly scanned out of order -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Alex Arnaud from comment #56) > But i don't understand why puting your code at line #113 should be a problem > if the test still pass. This is probably the clue. You should ;) My extra line should make the test fail since it does not reset back to original value (empty string instead of null). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|Patch doesn't apply |Needs Signoff --- Comment #101 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to David Gustafsson from comment #100) > (In reply to Tomás Cohen Arazi from comment #95) > > I think I might be repeating myself, probably on a different bug. But I > > think we should add both whitelisting and blacklisting 'MARC record overlay > > configurations', and then hook them into whatever place we want (i.e. for > > z39.50, for OAI harvsting, etc). It seems to me that we are duplicating > > efforts in some places, and solutions don't look generic enough. > > > > 'Protecting' is just a way to say you are blacklisting some fields on > > overlaying. > > Now rebased again, so should work with latest master. "Protecting" is > probably a little bit misleading to reflect what the patch currently does, > it has been largely refactored since the first version (which I did not > write). I have renamed it to MARC merge rules instead, since it is more of a > framework for auto-merging records according to a set or rules. I hadn't noticed that. We should change the bug name to reflect what this actually does. > My experience is that is is really tricky to get this right, and if trying to > fit it into another abstraction that might not be suited for this exact > purpose it could be more trouble than it's worth > (https://www.sandimetz.com/blog/2016/1/20/the-wrong-abstraction) While I agree with the assertion, I don't think it is the case. What I'm saying is that we could just add a boolean (whitelist/blacklist) to specify a different behaviour, using the same code and rules. That's something that would belong to a separate bug, of course. I just mentioned here because I thought 'Protect' could be avoided, which you already did :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #100 from David Gustafsson <glasklas(a)gmail.com> --- (In reply to Tomás Cohen Arazi from comment #95) > I think I might be repeating myself, probably on a different bug. But I > think we should add both whitelisting and blacklisting 'MARC record overlay > configurations', and then hook them into whatever place we want (i.e. for > z39.50, for OAI harvsting, etc). It seems to me that we are duplicating > efforts in some places, and solutions don't look generic enough. > > 'Protecting' is just a way to say you are blacklisting some fields on > overlaying. Now rebased again, so should work with latest master. "Protecting" is probably a little bit misleading to reflect what the patch currently does, it has been largely refactored since the first version (which I did not write). I have renamed it to MARC merge rules instead, since it is more of a framework for auto-merging records according to a set or rules. My experience is that is is really tricky to get this right, and if trying to fit it into another abstraction that might not be suited for this exact purpose it could be more trouble than it's worth (https://www.sandimetz.com/blog/2016/1/20/the-wrong-abstraction) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17137] New: Omnibus: Always use SSL when referencing external sources
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137 Bug ID: 17137 Summary: Omnibus: Always use SSL when referencing external sources Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Amazon, OpenLibrary, etc shoudl all use https if available as otherwise they create a mixed content error for sites using https. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79367|0 |1 is obsolete| | --- Comment #99 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 79370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79370&action=ed… Bug 14957 - Remove exports of removed subroutines Remove exports of subroutines previously removed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78652|0 |1 is obsolete| | --- Comment #98 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 79369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79369&action=ed… Bug 14957 - Refactor and fix tests and documentation Change "MARC permissions" to "MARC merge rules" since this is more descriptive of the feature provided. Update help page to reflect changes since large refactorization. Replace outdated tests with up to date tests. Improve rules admin UI adding "preset" setting. Move large part of added C4::Biblio code into Koha:: namespace. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78651|0 |1 is obsolete| | --- Comment #97 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 79368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79368&action=ed… Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenbug University Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78653|0 |1 is obsolete| | --- Comment #96 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 79367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79367&action=ed… Bug 14957 - Remove exports of removed subroutines Remove exports of subroutines previously removed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '18

25 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79347|Attachment to Bug 12446 - |Bug 12446 - Enable an adult description|Enable an adult to have a |to have a guarantor |guarantor | -- You are receiving this mail because: You are watching all bug changes.

1 0