September 2018 - Koha-bugs - lists.koha-community.org

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #47 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79252&action=ed… Bug 15494 - Add syspref Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #46 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79251&action=ed… Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #45 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79250&action=ed… Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71134|0 |1 is obsolete| | Attachment #71135|0 |1 is obsolete| | Attachment #71136|0 |1 is obsolete| | Attachment #71137|0 |1 is obsolete| | Attachment #71138|0 |1 is obsolete| | --- Comment #44 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79249&action=ed… Bug 15494 - Unit tests prove -v t/db_dependent/Circulation.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #211 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- qa comment test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com --- Comment #52 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #48) > Please correct above minor things. > > @Kyle: Please let me know if you agree with the changes in the third patch. > Saving me the time to study what happened there and what happens now. It > sure is a simplification, but hopefully not an oversimplification? I think this looks excellent! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10060] Self Checkout module does not honour circ control
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I haven't tested this. But you could have multiple patrons with the self-check permission and log in with them at different locations, I think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #86 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79246&action=ed… Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75661|0 |1 is obsolete| | Attachment #75662|0 |1 is obsolete| | Attachment #75663|0 |1 is obsolete| | --- Comment #85 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79245&action=ed… Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) -- You are receiving this mail because: You are watching all bug changes.

1 0