September 2018 - Koha-bugs - lists.koha-community.org

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #50 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #39) > 1. In tests, prefer > Koha::IssuingRules->search->update($what_you_need_to_be_set); > instead of the DELETE then INSERT. It makes the changes more readable in my > opinion. I generally agree, but circ rules are messy and this file has the same code existing. Should be refactored as a whole > 2. What about "NULL" string values? :) I think we expect a certain level of input from the user and are fairly thorough here > 3. Should not we have the same code for > OpacHiddenItems and ItemsDeniedRenewal (and UpdateNotForLoanStatusOnCheckin?) > There is also UpdateItemLocationOnCheckin (bug 14576) > > The minimum would be a new get_rules_from_prefs sub Moved to its own sub/module - changes for other prefs should be on their own reports > Ah! Not sure the reason is available in the template tho. The reasons are stored in the issues table, they should be available to templates -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #49 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79254&action=ed… Bug 15494: Move yaml syspref code to its own sub To test: 1 - prove -v t/db_dependent/Koha/Util/SystemPreferences.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #48 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79253&action=ed… Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t. Although the test does not fail, line 2127 contains two typos. Changing INVISILE to INVISIBLE :) And type should be itype. [2] Remove $yaml as leftover from older code. [3] Add a next when the split on /:/ does not give two results. This will prevent uninit warnings (although still disabled now in Circulation). [4] For the same reason we should switch the lines for NULL and empty string. The undefs you insert should trigger a warn. [5] The line for empty string should not insert undef, but empty string. For the same reason adding the condition defined($_) ... And proving it by adding two tests for the opposite values of callnumber and itemnotes. [6] Adding a strip spaces around the fieldname. User friendly.. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #47 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79252&action=ed… Bug 15494 - Add syspref Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #46 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79251&action=ed… Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #45 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79250&action=ed… Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71134|0 |1 is obsolete| | Attachment #71135|0 |1 is obsolete| | Attachment #71136|0 |1 is obsolete| | Attachment #71137|0 |1 is obsolete| | Attachment #71138|0 |1 is obsolete| | --- Comment #44 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79249&action=ed… Bug 15494 - Unit tests prove -v t/db_dependent/Circulation.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #211 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- qa comment test -- You are receiving this mail because: You are watching all bug changes.

1 0