September 2018 - Koha-bugs - lists.koha-community.org

[Bug 14741] Set permissions doesn't tick the top level check box and doesn't clear child check boxes
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '18

06 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 jdemuth(a)roseville.ca.us <jdemuth(a)roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth(a)roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '18

06 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77099|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 78452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78452&action=ed… Bug 13779: sessionID declared twice in C4::Auth::checkauth() The bug is that $sessionID is declared twice in C4::Auth::checkauth(). At the moment, this doesn't actually create a problem, because no one seems to be using the $sessionID which is returned by checkauth(), except in the case of opac/external/overdrive/auth.pl which skips the second declartion as it doesn't require auth. This patch removes the redefining of the $sessionID variable. In terms of testing, try logging in with a username and password and see if it works. The only risk this patch would pose is breaking auth I would think, since nothing is actually using the return value from checkauth() for $sessionID. NOTE: It was initially defined near the top of the function (~line 791). I believe the scoping would mean the correct version of $sessionID would be used in the latter lines for the unset'ing. I have skimmed code to see if the sessionID return value is used. I did not test overdrive, as I do not know how. However, this is the only area, I think this could possibly break. This change makes sense to me. QA: Please test overdrive. opac/external/overdrive/auth.pl only checks if the value is set, so this patch might fix/break something there? opac/svc/overdrive same kind of check. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '18

06 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16433] New: Patron import tool warning on duplicate card number is unclear
by bugzilla-daemon＠bugs.koha-community.org 05 Sep '18

05 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16433 Bug ID: 16433 Summary: Patron import tool warning on duplicate card number is unclear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If I am matching on userid, and import a patron with no userid in the file but the cardnumber is already used the warning says "Cardnumber ###### is not a valid cardnumber" It would be clearer if it said 'this cardnumber is already used' -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 05 Sep '18

05 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14302] Remove GRS1 indexing related code
by bugzilla-daemon＠bugs.koha-community.org 05 Sep '18

05 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14546] Make staff client templates responsive
by bugzilla-daemon＠bugs.koha-community.org 05 Sep '18

05 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 20690, which changed state. Bug 20690 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20690] New: Update two-column templates with Bootstrap grid: Acquisitions part 4
by bugzilla-daemon＠bugs.koha-community.org 05 Sep '18

05 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690 Bug ID: 20690 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 20668 Blocks: 14546 This patch will convert even more acquisitions templates to use the Bootstrap grid: - acqui/orderreceive.tt - acqui/parcel.tt - acqui/parcels.tt - acqui/spent.tt - acqui/supplier.tt - acqui/uncertainprice.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2 -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 14546] Make staff client templates responsive
by bugzilla-daemon＠bugs.koha-community.org 05 Sep '18

05 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 20672, which changed state. Bug 20672 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 3 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20672 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20672] New: Update two-column templates with Bootstrap grid: Acquisitions part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Sep '18

05 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20672 Bug ID: 20672 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 14546 This patch will convert even more acquisitions templates to use the Bootstrap grid: neworderbiblio.tt neworderempty.tt newordersubscription.tt newordersuggestion.tt neworderempty_duplicate.tt ordered.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive -- You are receiving this mail because: You are watching all bug changes.

1 15