September 2018 - Koha-bugs - lists.koha-community.org

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #104 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- The rebased patches should now apply cleanly on master (as of 5/9/2018), as shown below: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Applying: Bug 15565: CSS changes Applying: Bug 15565: Use item's biblionumber only on item-level request Applying: Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Applying: Bug 15565: Alert librarian that maximum holds per record is reached Applying: Bug 15565: Remove use of GetBiblionumberFromItemnumber Applying: Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC Applying: Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl Applying: Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #103 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78426&action=ed… Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds This commit implements changes to opac-reserve.tt and opac-reserve.pl. 1. The change to opac-reserve.tt JS fixes the total_requested() function which returns an output which is always 2 digits higher than the actual number of selected item checkboxes. i.e. if the 'maxreserves' syspref (limit for the overall number of reserves allowed by a user) is 4 and a user has no previous holds and ticks 3 item checkboxes and submits the form. The 'Maximum number of reserve exceded.' popup message is displayed, however as they have selected 3 items for reservation this is less than the maxreserves value of 4. The popup is displayed because total_requested() JS function is returning 5 (i.e. 2 on top of the actual number of requested holds). This commit usbtracts 2 from the number of holds calculated by total_requested() so that the accurate number of requested holds is being used to determine whether or not to display the excess holds popup. 2. When the 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref are the same value (e.g. 4) you can tick 4 item checkboxes in opac-reserve.pl and submit the form. The form will submit successfully and to the user everything looks to have worked however the holds will not be successfully created. This is because after the form is submitted to opac-reserve.pl a check is done: If 'number of submitted hold requests' + 'number of previous existing holds' greater than or equal to maxreserves syspref then set the variable '$canreserve' to 0. If the $canreserve variable is 0 the form will submit, no warning/error message is displayed to the user but the holds are not created. Users should be able to place 4 holds if the maxreserves syspref is 4 (just not more than 4 holds). This commit changes this check to: If 'number of submitted hold requests' + 'number of previous existing holds' greater than maxreserves syspref then set the variable '$canreserve' to 0.. i.e. notice we only check for greater than (not equal to). Which solves the bug of the form submitting and no holds being created when the maxreserves syspref and 'Holds per record (count)' (circulation rule) are the same. Test plan (in two parts to test fix #1 and #2 (above)): Test plan for fix #1: 1. Apply all patches on this bug report (15565) and follow and confirm the feature works as described in the test plan in the first commit 2. Set the 'maxreserves' syspref to 3 (and 'Holds per record (count)' (circulation rule) to 5) 3. Ensure your logged in patron account has no existing reserves 4. In the OPAC go to a biblio page with 3 or more items 5. In the reservation page (opac-reserve.pl) for that biblio select 2 item checkboes to place 2 item level holds and notice the 'Maximum number of reserve exceded.' popup message is displayed. As the maxreserves syspref value is 3 you should be able to place 2 holds without exceeding that value 6. Apply this patch 7. Repeat step 5 and notice the form submits without the exceeding popup message and the holds are successfully placed. Test plan for fix #2: 1. Apply all patches attached to this bug report (bug 15565) and perform the test plan in the first commit and verify it works. 2. Set your 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref to the same value 3 3. Go to a biblio in the OPAC with 3 or more items 4. In the opac-reserve.pl reservation interface for that biblio tick 3 item checkboxes to place 3 item level holds and submit the form. 5. Notice the form submits and no warning/error message is displayed 6. In the opac user summary page that is displayed after the reserve form is submitted notice the holds are not displayed this is because they have not been placed 7. Apply this patch 8. Repeat step 4 and 5 and notice the holds have been successfully placed and are displayed in your opac user summary page. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #102 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78425&action=ed… Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl Previously the selected branch dropdown value was not being successfully retrieved in opac-reserve.pl, this resulted in opac holds being placed with no pickup branch being set. Consequently as no branch was associated with the hold an Ajax error was thrown when viewing the holds-table in the patron page in the staff client. This commit successfully retrieves the selected branch value and so fixing the Ajax error. Test plan: 1. Apply all patches on bug report 15565 except this commit 2. Place a hold(s) from opac-reserve.pl. 3. Go to your opac patron summary page (opac-user.pl) and notice although the holds are successfully displayed they have no 'Pickup location' value 4. Go to the patron page in the staff client and click on the 'Hold(s)' tab and notice a popup explaining the datatable Ajax error is loaded 5. Apply this patch 6. Repeat step 3 noticing this time in the opac-user.pl a 'Pickup location' is displayed for the hold you just created. 6. Repeat step 4 and notice the hold datatable is successfully loaded and populated without an Ajax error popup being loaded. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #101 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78424&action=ed… Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC This commit fixes two bugs: 1. C4::Reserves->CanItemBeReserved() returns an output in a hash in the format: status => 'output' However opac-reserve.pl is not accessing th output of this function correctly consequently no item is ever reservable. And so after a patron submits the reservation form on opac-reserve.pl it looks like the item-level reservation has successfully been placed however it has not and no error message is displayed to them. This commit stores the output of the aforementioned function in a hash and then checks the value of the status key. As a result opac-reserve.pl now correctly accesses the value returned and item level holds are successfully placed from the OPAC. 2. If a biblio has previously been reserved then the opac-reserve.pl page shows the 'Next available item' and 'A specific item' radio buttons to be disabled to ensure patrons cannot place a reservation of a different type on the biblio. With both of these radio buttons being disabled it results in item level holds placed in the OPAC on a previously reserved item not being stored in the database. This is very confusing for users. I have implemented a conditional which checks what the forced_hold_type of the previous hold was. If it was 'item' then the $reqtype = 'Specific' and if it was 'record' then $reqtype is 'Any'. This means there will always be a value for $reqtype, and this variable is checked if it is equal to 'Specific' and if it is then an item level hold is placed. Test plan: 1. Ensure in your circulation rules that 'Item level holds' is enabled 2. Apply all patches on this bug report except this commit 3. In the OPAC try placing a item level hold (and notice you can submit the opac-reserve.pl page and no error messages are displayed. However the hold(s) are not being placed. 4. Place an item level hold(s) on the biblio from staff client interface and then return to the opac-reserve.pl page for the biblio in the OPAC and notice both the 'Next available' and 'A specific item' radio buttons are disabled. 5. Again try placing an item level hold in the OPAC and notice dispite no error/warning message being displayed the hold is not being placed. 6. Apply this patch 7. Restart memcached, and plack 8. In the staff client remove the reservation you placed from the staff client. 9. Repeat step 3 and notice when you go to your opac summary (opac-user.pl) page the holds are displayed. .i.e. You can now successfully place item level holds in the OPAC. 10. Return to the opac-reserve.pl page for the biblio and notice that because you have already placed a hold on this biblio the 'Next available item' and 'A specific item' radiobuttons are disabled. 11. Select several of the items checkboxes to place more item level holds and press the 'Confirm hold' button. 12. Go to your opac summary (opac-user.pl) page again and notice the holds you placed in step 11 are shown there. i.e. you can place item level holds from the OPAC on biblios which have previously had reserves placed on them. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #100 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78423&action=ed… Bug 15565: Remove use of GetBiblionumberFromItemnumber Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #99 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78422&action=ed… Bug 15565: Alert librarian that maximum holds per record is reached Signed-off-by: Dani Elder <dani(a)bywatersolutions.com> Signed-off-by: Danielle Elder <danielle(a)bywatersolution.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #98 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78421&action=ed… Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Signed-off-by: Danielle Elder <danielle(a)bywatersolution.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #97 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78420&action=ed… Bug 15565: Use item's biblionumber only on item-level request Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #96 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78419&action=ed… Bug 15565: CSS changes Note: Reworked as we have switched to CSS since this commit was first written. This commit now contains 2 files: * koha-tmpl/opac-tmpl/bootstrap/css/opac.css * koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '18

04 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78245|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0