January 2019 - Koha-bugs - lists.koha-community.org

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 83630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83630&action=ed… Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- After some debugging I think I have found the reason. It won't work with the numeric value of the authorised value used, it needs the description: restricted: ['Restricted Access'] For other values like Damaged it will works with numerics. The reason is some code in GetItemsInfo: # get notforloan complete status if applicable $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => $data->{frameworkcode}, kohafield => 'items.notforloan', authorised_value => $data->{itemnotforloan} }); $data->{notforloanvalue} = $descriptions->{lib} // ''; $data->{notforloanvalueopac} = $descriptions->{opac_description} // ''; # get restricted status and description if applicable $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => $data->{frameworkcode}, kohafield => 'items.restricted', authorised_value => $data->{restricted} }); $data->{restricted} = $descriptions->{lib} // ''; $data->{restrictedopac} = $descriptions->{opac_description} // ''; While it uses a new variable "*value*" for notforloan, it overwrites the restricted numerical value with the description. I think the clean solution is to change it so that OpacHiddenItems works like for the other item fields with authorised values, using the codes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Joy, I tested again today on master - it still doesn't work for me. Here is what I did: OpacHiddenItems: restricted: [1] Changed 1 item out of 4 to be restricted. Opac now shows it as: Available (Restricted Access) Not hidden... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11962] New 'cluster' install mode
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11962 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '19

03 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thank you, Joy, that's good news! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21807] New: Allow choosing narrower/broader when linking authority hierarchies
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '19

03 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21807 Bug ID: 21807 Summary: Allow choosing narrower/broader when linking authority hierarchies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The idea is that instead of just picking the 'Choose' button, the end-user can choose if the selected one is a narrower or a broader term, and thus filling $w accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '19

03 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #5 from Joy Nelson <joy(a)bywatersolutions.com> --- Katrin, I've just tested this on 18.06.00.028 and it is working. Restricted items are being hidden in the OPAC when a value of restricted: [1] is placed in the OPACHiddenItems syspref. (In reply to Katrin Fischer from comment #4) > Tested on 17.11 again - still not working. Looking at the code I don't see a > reason for it not working. lost and damaged are also numerical and work > without issues, but restricted does not. > > It doesn't appear to be a reserved word in SQL... out of ideas. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6495] After deleting a list the output of lists is truncated
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '19

03 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6495 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 21693] New: Clean up checkout notes template
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '19

03 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Bug ID: 21693 Summary: Clean up checkout notes template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/checkout-notes.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 20654 The checkout notes template has several issues which need to be cleaned up: - Bootstrap grid - DataTables configuration improvement - Change toolbar position to better match established patterns Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 18