January 2019 - Koha-bugs - lists.koha-community.org

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83438|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 83664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83664&action=ed… Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #17 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- (In reply to Katrin Fischer from comment #14) > (In reply to Pierre-Marc Thibault from comment #11) > > All seems allright, except the last step where the item doesn't show up when > > OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for > > you? > > Yes it did work - when the pref is empty and read correctly, there is no > more reason to hide it for Koha. > > Can you please check that the item didn't fit another criteria for being > hidden? > Is your system preference OpacHiddenItems really empty? > Is your system set up with memcached and Plack? Sorry, it was likely a mistake on the refresh of the content. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #16 from Joy Nelson <joy(a)bywatersolutions.com> --- Testing with Nick shows that this is dependent on the number of items. My test were for a bib with 1 item and that item was restricted. It does hide the title from the OPAC because the one item is 'hidden'. However when another item is added, the hidden item does not appear in search results (as available), but does appear in the detail page when the title is clicked on. (In reply to Joy Nelson from comment #15) > My framework is the Default framework. 952$5 is tied to RESTRICTED > authorized value list. The RESTRICTED auth value list has code of 1 and > description of "Restricted Access". > > OpacHiddenItems contains (with a blank line at end) > itype: [GAMES,EBOOK] > ccode: [REFERENCE,MUSIC] > location: [HOMESCHOOL,PARENTING] > restricted: [1] > > My item was none of the values listed below and appeared in OPAC searches. > When i edit the item to RESTRICTED (items.restricted=1), it dissappears from > searches. Although number of bibs still show the count of 5, where search > results only show 4. > > (In reply to Katrin Fischer from comment #13) > > Hi Joy, is it possible you used a framework that was not linked to the > > authorised value correctly? Looking at the code it can't work with the > > number, unless the number is in the description or the authorised value > > description cannot be found. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #15 from Joy Nelson <joy(a)bywatersolutions.com> --- My framework is the Default framework. 952$5 is tied to RESTRICTED authorized value list. The RESTRICTED auth value list has code of 1 and description of "Restricted Access". OpacHiddenItems contains (with a blank line at end) itype: [GAMES,EBOOK] ccode: [REFERENCE,MUSIC] location: [HOMESCHOOL,PARENTING] restricted: [1] My item was none of the values listed below and appeared in OPAC searches. When i edit the item to RESTRICTED (items.restricted=1), it dissappears from searches. Although number of bibs still show the count of 5, where search results only show 4. (In reply to Katrin Fischer from comment #13) > Hi Joy, is it possible you used a framework that was not linked to the > authorised value correctly? Looking at the code it can't work with the > number, unless the number is in the description or the authorised value > description cannot be found. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Pierre-Marc Thibault from comment #11) > All seems allright, except the last step where the item doesn't show up when > OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for > you? Yes it did work - when the pref is empty and read correctly, there is no more reason to hide it for Koha. Can you please check that the item didn't fit another criteria for being hidden? Is your system preference OpacHiddenItems really empty? Is your system set up with memcached and Plack? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Joy, is it possible you used a framework that was not linked to the authorised value correctly? Looking at the code it can't work with the number, unless the number is in the description or the authorised value description cannot be found. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #12 from Joy Nelson <joy(a)bywatersolutions.com> --- My testing of the original issue (on 18.06) could not replicate it. I was using the code for the Restricted value, not the description. The items were hidden on the opac when Restricted: [1] was in the opachiddenitems. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |pierre-marc.thibault@inlibr | |o.com --- Comment #11 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- All seems allright, except the last step where the item doesn't show up when OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for you? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15912] New: Correct JSHint errors in acq.js
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15912 Bug ID: 15912 Summary: Correct JSHint errors in acq.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: koha-bugs(a)lists.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in datatables.js koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 35, col 58, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 45, col 19, Use '===' to compare with 'true'. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 50, col 33, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 56, col 26, Use '===' to compare with 'true'. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 56, col 51, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 58, col 26, Use '===' to compare with 'true'. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 63, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 81, col 9, 'iDelay' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 113, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 136, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 454, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 460, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 548, col 23, Don't make functions within a loop. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 555, col 6, Unnecessary semicolon. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

1 2