November 2019 - Koha-bugs - lists.koha-community.org

[Bug 13806] No input sanitization where creating Reports subgroup
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95733|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 95817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95817&action=ed… Bug 13806: No input sanitization where creating Reports subgroup This patch adds validation of report group and subgroup inputs so that the user can't enter data into only one half of the group code/name pair. To test, apply the patch and go to Reports -> Use saved. - Create or edit a report which doesn't have a group or subgroup assigned. - Under "Report group," select the "or create" radio button. - Click the "Update SQL" button to submit the form without entering a group code or name. The form should require taht you enter data into both fields. - Enter data into the report group code and name fields. Add data to either the code or data field under "Report subgroup." You should not be able to submit the form without populating both. - Start over editing a report which doesn't have a group or subgroup assigned. - Select an existing group under "Report group." - Under "Report subgroup," select the "or create" option. - You should not be able to submit the form without adding data in both the code and name fields for the report subgroup. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13806] No input sanitization where creating Reports subgroup
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23006] New: Can't use inventory tool with barcodes that contain regex relevant characters ($, ...)
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006 Bug ID: 23006 Summary: Can't use inventory tool with barcodes that contain regex relevant characters ($,...) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- If your barcodes contain characters like $ (and possible others), it's not possible to use the inventory tool with a barcode file as they will report as 'not scanned', while the datelastseen is still updated. We have a library system that uses barcodes with the following schema: LOCATION_CODE$DIGITS When uploading a file with such barcodes in the inventory tool, they all report as missing. Exceptions are items that are on the wrong place on the shelf, they report correctly. The datelastseen is updated for all items anyway. To test: 1) Create an item with the following barcode: LOC$00001 2) Create a file with the same barcode on the first line. 3) Go to the inventory tool 4) Upload barcode file Check "Compare barcodes list to results" Check "Do not check in items scanned during inventory" Check "Skip items on loan" You might want to pick additional limits for a smaller result set depending on your sample db size, make sure it matches the item catalogued 5) Verify the scanned item is in the list, but the status reads "Missing (not scanned)". I found this regex in the perl code: if( !$barcode ) { $item->{problems}->{no_barcode} = 1; } elsif ( grep /^$barcode$/, @scanned_barcodes ) { next; } else { $item->{problems}->{not_scanned} = 1; } I assume that grep /^$barcode$/ fails because of the unescaped $. Is there a good way to make sure all problematic characters are escaped? Is the grep really necessary here? Later on we make the comparisons differently which is why the "wrongplace" still appears correctly and probably also why the datelastseen is updated as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 [Bug 24113] guarantor info lost when a duplicate is found -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15142] Titles facet does not work in UNIMARC
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- (In reply to Jonathan Druart from comment #7) > Should not it be removed from xsl and xml files in > etc/zebradb/marc_defs/unimarc/biblios? Yes indeed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15142] Titles facet does not work in UNIMARC
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 --- Comment #8 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Created attachment 95810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95810&action=ed… Bug 15142: (follow-up) remove from Zebra UNIMARC config files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6994] 'No budget defined' showing up although budgets and funds are defined
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6994 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24111 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 [Bug 24111] Incorrect "Can't create any orders" alert -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 [Bug 24110] Template vars are incorrectly html filtered when dumped -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13326] Add possibilty to edit purchase suggestion on opac
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13326 Ray Delahunty <r.delahunty(a)arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty(a)arts.ac.uk --- Comment #2 from Ray Delahunty <r.delahunty(a)arts.ac.uk> --- Currently a suggestion that is deleted by the user who submitted it via their account sees the data in the suggestions table deleted. This can be even AFTER the suggestion has been accepted, the user notified, and the ordering process has started. For us this is unwelcome functionality as we want to record counts of purchase suggestions. We will be looking at using jquery to hide the delete functionality in the user account. We did consider adding an old_suggestions table as well, so we could archive suggestions (such as those made in a previous academic year), so we note and are delighted with the development work for bug 22784. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23672] New: Dependency graph colours missing
by bugzilla-daemon＠bugs.koha-community.org 25 Nov '19

25 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23672 Bug ID: 23672 Summary: Dependency graph colours missing Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com I may be imagining it, but didn't the 'Show dependency graph' feature used to give us more colours? It now appears to only show green or grey.. I'm sure we had reds and oranges before to denote bug status at a glance. -- You are receiving this mail because: You are watching all bug changes.

1 9