November 2019 - Koha-bugs - lists.koha-community.org

[Bug 9553] Link authorities to bibs when imported
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9553 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #45 from Séverine Queune <severine.queune(a)bulac.fr> --- Thank you Maryse ! The new version is ok for me :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95419|0 |1 is obsolete| | --- Comment #44 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 95441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95441&action=ed… Bug 12502: (follow-up) Adds formatting for datatables export Add a format option to the datatables export that remove .noExport elements present in a data cell, just as .noExport columns are not exported. To test: 1. For late orders (which uses .noExport elements in data cells) : Export data in any format using the export button at the top of the datatable. => data should exclude "Add/Edit note" label, but otherwise look the same as before the patch. 2. Try exporting data in other datatables in Koha and make sure exported data is the same before and after applying the patch. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95418|0 |1 is obsolete| | --- Comment #43 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 95440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95440&action=ed… Bug 12502: (QA follow-up) Remove the Save button Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91564|0 |1 is obsolete| | --- Comment #42 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 95439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95439&action=ed… Bug 12502: (follow-up) Use modal to add/edit order notes Replace inputs to edit notes by a link opening a modal, similar to the basket summary page. This makes it possible for the notes to appear in the datatable exports. Also fix exporting with the export as csv button at the bottom of the page to export notes. Test plan : 1) In the late orders table (acqui/lateorders.pl), a link should appear in both the internal and vendor note column, following the current value if it exist. -> This link should read "Add ..." if there is no existing note or "Edit ..." if there is. 2) Click on the link. A modal should appear. Confirm that saving a note works as expected. 3) Try exporting to any format using either the button at the top of the table or the one at the bottom of the page. -> The three new columns and their values should appear in the export. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87236|0 |1 is obsolete| | --- Comment #41 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 95438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95438&action=ed… Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders page Test plan: 0) Make sure you have a late order a) Create a test vendor unless you have one b) Create a test basket unless you have one c) Close the basket to mark the order as late 1) Go to the late orders table Before patch : Orderno, ISBN, vendor notes, internal notes are absent After patch: fields are present 2) Edit the vendor note and/or the internal note 3) Press the save notes button 4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your modifications should be displayed. Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23589] New: Discharge notice does not show non-latin characters
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 Bug ID: 23589 Summary: Discharge notice does not show non-latin characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: theod(a)lib.auth.gr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The discharge notice skips any non latin characters, whether in notice body or in patron details. You can verify this by either: a) modifying the default discharge notice slip and entering a non latin string [ie. "Δοκιμή" (which means testing in Greek)] b) modifying a user firstname/lastname, etc and printing <<borrowers.firstname>> <<borrowers.surname>> in discharge notice slip In current master (Sep. 2019), in both cases, the non-latin strings will be skipped in the pdf output. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #40 from Maryse Simard <maryse.simard(a)inlibro.com> --- Thank you for testing and for your comment. I would say the different behaviors for the export buttons is expected since the button as the top is a part of the datatables plugin and uses it's filters to determine which row to export and the button at the bottom is part of Koha and uses the checkboxes to filter rows to export. I agree this behavior might be questionable, but I believe it is not in the scope of this bug which is about order notes. I did forget to remove the "Save notes" button, thank you for the catch. I've also added a patch to remove the "Add/Edit note" label. It adds a new formatting option to the datatables to accept the use of the .noExport class on data cell elements to remove them from exported data. It is now ready to be tested again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '19

14 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #39 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 95419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95419&action=ed… Bug 12502: (follow-up) Adds formatting for datatables export Add a format option to the datatables export that remove .noExport elements present in a data cell, just as .noExport columns are not exported. To test: 1. For late orders (which uses .noExport elements in data cells) : Export data in any format using the export button at the top of the datatable. => data should exclude "Add/Edit note" label, but otherwise look the same as before the patch. 2. Try exporting data in other datatables in Koha and make sure exported data is the same before and after applying the patch. -- You are receiving this mail because: You are watching all bug changes.

1 0