November 2019 - Koha-bugs - lists.koha-community.org

[Bug 23973] New: Serials module broken by Swedish translation
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23973 Bug ID: 23973 Summary: Serials module broken by Swedish translation Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com One customer recently upgraded to 19.05.04.000 (Debian packages). After the upgrade the serials module is broken when they view the Swedish translation, but not when they view it in English. The most visually striking problem is that both page 1 and 2 of the serials form is displayed on one page. I have narrowed the problem down to koha-tmpl/intranet-tmpl/prog/sv-SE/modules/serials/subscription-add.tt line 509 which looks like this in the Swedish translation: var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %][% END %]; and this in the English original: var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %]0[% END %]; Notice the missing 0 between ELSE and END in the Swedish template. I have tried to look through the Swedish staff .po file, but I have not been able to spot any strings that affect this area of the file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #29 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 95061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95061&action=ed… Sample marc record to illustrate display -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #28 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 95060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95060&action=ed… Bug 7611: (follow-up) Fix display of undefined statuses and add a class -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Nick Clemens <nick(a)bywatersolutions.com> --- Okay, I reviewed this, what it does is that: Available doesn't change Items marked 'not for loan' at itemtype level go into 'Available for reference' Items marked 'not for loan' individually, whether negative or positive, are displayed in the 'unavailable' section with the description of the 'not for loan' status showing. If you have several not for loan statuses with the same description, e.g. 'Available for reference' then they will be displayed together in the unavailable section It also adds some classes and styling to allow for the end user to adjust using css/jquery I am attaching a smaple record as described in the test plan which you can import if using the default database. You will need to add a 'NOT_LOAN' value of 4 with opac description 'Ordered' to see it in operation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23972] New: No property remove_debarment for Koha::Patron
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23972 Bug ID: 23972 Summary: No property remove_debarment for Koha::Patron Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: - Make sure you have a borrower with a debarment - Go to the full "patron edit" screen, e.g. /cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=1&categorycode=STAFF - Tick the checkbox for "Remove?" connected with the debarment - Click "Save" on the floating toolbar on the top of the screen - Observe the "Internal Server Error" message - Check the plack-error.log and it should say just "No property remove_debarment for Koha::Patron" Tested on a debian package install of Koha 18.11.03. (I also tested on current master, but could NOT reproduce the problem there.) I tried to grep for instances of remove_debarment being used as a property of a Koha::Patron object, but with no luck: $ grep -rn remove_debarment * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: 954: <input type="checkbox" id="debarment_[% d.borrower_debarment_id | html %]" name="remove_debarment" value="[% d.borrower_debarment_id | html %]" /> members/memberentry.pl: 112: my @debarments_to_remove = $input->multi_param('remove_debarment'); members/memberentry.pl: 224: qr/^add_debarment$/, qr/^debarred_expiration$/, qr/^remove_debarment$/, # We already dealt with debarments previously -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 23082] New: Fatal error editing a restricted patron
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Bug ID: 23082 Summary: Fatal error editing a restricted patron Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: frinaudo(a)infocpt.com.ar QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- Para reproducir el error, se debe tener un socio con una restricción, ya sea manual o automática: 1- Editar el socio 2- Marcar el checkbox "eliminar" en la restricción 3- Guardar En ese momento aparece un internal server error En los logs el mensaje es: ==> /var/log/koha/eco/plack-error.log <== No property remove_debarment for Koha::Patron La restricción se elimina, pero se debe abrir una ventana de koha nuevamente. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 11514] "Uncertain" no longer display in acq
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11514] "Uncertain" no longer display in acq
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93323|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95043&action=ed… Bug 11514: Untranslatable "Uncertain" text in acq This patch modifies two pages so that the "Uncertain price" information is shown by the template rather than the Perl script, making the text translatable. To test, apply the patch and go to Acquisitions. - Locate or create an order in a basket which has an uncertain price. - When viewing the contents of that basket the order which was marked as having an uncertain price should be labeled "Uncertain." - The same should be true for the invoice page. If you don't have an existing invoice with an "uncertain" order, - Go to "Receive shipments" for the vendor your "uncertain" order is with. - Create a new invoice. - Receive one or more orders which has an uncertain price. - Press the "finish receiving" button. - In the "Invoice details" section of the invoice page you should see the "Uncertain" label on the correct order. Signed-off-by: Christophe Croullebois <christophe.croullebois(a)biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> For the invoice view: close, receive, reopen, mark prices uncertain, go to the invoice page (not sure it's expected however) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11514] "Uncertain" no longer display in acq
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11514] "Uncertain" no longer display in acq
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '19

05 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0