November 2019 - Koha-bugs - lists.koha-community.org

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #30 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Nick Clemens from comment #27) > Okay, I reviewed this, what it does is that: > Available doesn't change > Items marked 'not for loan' at itemtype level go into 'Available for > reference' > Items marked 'not for loan' individually, whether negative or positive, are > displayed in the 'unavailable' section with the description of the 'not for > loan' status showing. > > If you have several not for loan statuses with the same description, e.g. > 'Available for reference' then they will be displayed together in the > unavailable section > > It also adds some classes and styling to allow for the end user to adjust > using css/jquery > > I am attaching a smaple record as described in the test plan which you can > import if using the default database. You will need to add a 'NOT_LOAN' > value of 4 with opac description 'Ordered' to see it in operation Hi Nick, first: thank you for the summary! Second: I am sorry, it just doesn't feel quite right yet to me :( I am trying to put into words, but please feel free to get others opinions as well. >Items marked 'not for loan' at itemtype level go into 'Available for reference' >Items marked 'not for loan' individually, whether negative or positive, are displayed in the 'unavailable' section with the >description of the 'not for loan' status showing 1) We have built on the fact that the not-for-loan works the same on item type as on individual level and I think this change might be controversial. With the patch, itype level 'not for loan' is green, but individual show red = different messages. Koha defines available as 'on the shelf' not as 'loanable' in my understanding - so green seems the better default choice. 2) The display with the extra break looks like we are missing a label (I think it's intended, but that's the impression I get): Availability: Items available for loan: Midway (1). Centerville Staff Collection (1). Or with some more items: Availability: Items available for loan: Centerville (1). Items available for reference: Centerville (1). Centerville Staff Collection (1). Damaged (1). I think I'd opt for removing the line break and always displaying the "Itmes available for reference:" when there is at least one item with a not for loan value. That would mean the first example would look like this: Availability: Items available for loan: Midway (1). Items available for reference: Centerville Staff Collection (1). And the second could be like this, using a comma between different values: Availability: Items available for loan: Centerville (1). Items available for reference: Centerville (1), Centerville Staff Collection (1). Damaged (1). Just notes (no lockers at all): I see that you use individual CSS classes on the items, I like that. Just wondering: currently we use the description, so a description change will mean the CSS needs to change as well. On the other side: not for loan values are numeric and we are grouping the onces with the same name and I like that - so that's probably the best way. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani <bouzid.fergani(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94818|0 |1 is obsolete| | --- Comment #102 from Bouzid Fergani <bouzid.fergani(a)inlibro.com> --- Created attachment 95126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95126&action=ed… Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> https://bugs.koha-community.org/show_bug.cgi?id=12299 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani <bouzid.fergani(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23075] New: Incorrect URL should have a meaningful error message
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Bug ID: 23075 Summary: Incorrect URL should have a meaningful error message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Mana-kb Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com Target Milestone: --- Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 68

[Bug 21406] New: Not adding author to request can cause JS errors
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Bug ID: 21406 Summary: Not adding author to request can cause JS errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com If an ILL request does not contain an author, when viewing the ILL requests table, the following errors are displayed by Datatables: DataTables warning: table id=ill-requests - Requested unknown parameter 'metadata_Author' for row 0, column 0. For more information about this error, please see http://datatables.net/tn/4 DataTables warning: table id=ill-requests - Requested unknown parameter 'metadata_Author' for row 358, column 0. For more information about this error, please see http://datatables.net/tn/4 We need better handling of requests without populated author in the JS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 11514] "Uncertain" no longer display in acq
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11514] "Uncertain" no longer display in acq
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95114&action=ed… Bug 14973: Add missing filters in templates -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95113&action=ed… Bug 14973: Remove double declaration of suggestions_loop -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23945] New: koha-remove does not support older mysql and mariadb
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '19

06 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Bug ID: 23945 Summary: koha-remove does not support older mysql and mariadb Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org koha-remove utilises IF EXISTS in the DROP USER calls and this was only introduced in later versions of MySQL and MariaDB.. as such it breaks on many otherwise stable distributions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11