December 2019 - Koha-bugs - lists.koha-community.org

[Bug 23947] New: Phase out jquery.cookie.js: Authority merge
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '21

22 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 Bug ID: 23947 Summary: Phase out jquery.cookie.js: Authority merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 23944 The authority merge process sets cookes to track which records are being merged. This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 18146] New: C4:: Circulation CanBookBeRenewed lacks full test coverage.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18146 Bug ID: 18146 Summary: C4::Circulation CanBookBeRenewed lacks full test coverage. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com While testing bug 17941, I discovered two cases where test coverage was lacking from t/db_dependent/Circulation.t Around line 2725: if ( $restricted and $restrictionblockrenewing ) { return ( 0, 'restriction'); } elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') || ($itemissue->{overdue} and $overduesblockrenewing eq 'blockitem') ) { return ( 0, 'overdue'); } The elseif is never triggered. Around line 2759: if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) ) { return ( 0, "auto_too_soon" ) if $itemissue->{auto_renew}; return ( 0, "too_soon" ); } elsif ( $itemissue->{auto_renew} ) { return ( 0, "auto_renew" ); } There is no else, but the code never attempts something that would trigger one. To reproduce add: print STDERR "CHECK!\n"; just before the return ( 0, 'overdue') in the first case, and after the elsif's curly brace in the second case. running t/db_dependent/Circulation should not generate the CHECK points. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 22713] New: Replacement price removed when receiving if using MarcItemFieldstoOrder
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Bug ID: 22713 Summary: Replacement price removed when receiving if using MarcItemFieldstoOrder Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: nick(a)bywatersolutions.com Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88048&action=ed… replacement price in item record acq process In 18.11 the wording and functionality changed in Acquisitions with the field Replacement price. This allowed libraries to have their replacement price set in the Acquisitions order and also in the item record. However, if a library is using MarcItemFieldstoOrder system preference and setting their replacement price in the marc record upon Importing. The replacement price only stays on the Item Record and will not be included into the Acquisitions order and it won't populate into the receiving process- and therefore making it $0. It would be nice if the item record had the replacement price from the MarcItemFieldstoOrder, and this would follow it through the process and since it is there in the item, it be used in the Order. Process currently: 1. Set marcitemfieldstorder to have a $v replacement price (975$v) 2. Create a basket 3. Upload a marc file that has a replacement price in the record 4. Add this file to your basket. 5. The item record will display the replacement price. 6. The basket.pl will not display the replacement price of this item 7. CLose the basket 8. When receiving the item in Acquisitions, the replacement price is zeroed out 9. The item will not have a replacement price once it is received. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 22838] New: Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous'
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '21

16 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 Bug ID: 22838 Summary: Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Target Milestone: --- Explicitly setting a MIME header field (content-type) is dangerous: use the attr() method instead. at misc/cronjobs/runreport.pl line 312. It seems the error comes from Koha/Email.pm: 72 $mail{'Content-Type'} = $params->{contenttype} if $params->{contenttype}; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 23926] New: In EDI Order limit GIR segment to five pieces of information
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '21

15 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Bug ID: 23926 Summary: In EDI Order limit GIR segment to five pieces of information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org In the specification for the GIR segment it states If there are more than five items of information for one copy or for one part order, the segment may be repeated with the same copy or part-order sequence number in DE 7297 This was something we initially did not need to do as we have limited locations to store GIR data. This is no longer the case as some sites are using this for other data codes, so we need to implement the standard format -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 23544] New: Advanced search: Allow to select more than one language for searching
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '21

15 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23544 Bug ID: 23544 Summary: Advanced search: Allow to select more than one language for searching Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org You can currently search by language by using the pull down in the advanced search in staff and OPAC. This only works for one language at a time. It would be nice, if more than one language could be selected and searched for. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 23485] New: Holds to pull (pendingreserves.pl) shoudl list barcodes
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485 Bug ID: 23485 Summary: Holds to pull (pendingreserves.pl) shoudl list barcodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If you have an item level hold the 'Holds to pull' list needs to tell you which barcode in the case of several items being on the shelf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 43

[Bug 23763] New: Move pagination calculations to a subroutine
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23763 Bug ID: 23763 Summary: Move pagination calculations to a subroutine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Currently we duplicate some code used to build pagination parameters needed for page-numbers.inc, we should make this a subroutine and test it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 22243] New: Advanced Cataloguer editor fails if the target contains an apostrophe in the name
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Bug ID: 22243 Summary: Advanced Cataloguer editor fails if the target contains an apostrophe in the name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Target Milestone: --- As the title, if a z39.50 target has an apostrophe in the name, the editor fails with an "Unexpected token" Javascript error. The array containing the targets is constructed then embedded in the page template and, since the string is enclosed in unescaped single apostrophes, things fall over. The fix is to replace ' in target names with ' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 20971] New: additem Corrupted storable string
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Bug ID: 20971 Summary: additem Corrupted storable string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Sometimes additem.pl will complain about "Storable::thaw failed to thaw LastCreatedItem-cookie.", see bug 14844. Now, actually fix the bug. The bug is caused by trying to URI (un)escape MARC::Record, binary data. We'll use a base64 url-safe version instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19