December 2019 - Koha-bugs - lists.koha-community.org

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 [Bug 24208] Remove change calculation for writeoffs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Jonathan Druart from comment #29) > What about the following structure: > ... > > I do not think we should force to have the same number of fields. What if > you want the default value for instance? That's not a big deal but I would > prefer to get rid of this limitation since the beginning :) Maybe I'm wrong but to do that we'll need to do a prepare/execute for each row, because we won't know which columns are necessary; and this could be slower ( https://docstore.mik.ua/orelly/linux/dbi/ch05_05.htm ) Columns must be absent on insert statement for them to use default values. It'll be equivalent to a $dbh->do() for each row. Or we can fill missing values with empty/NULL my @values = map { $row->{$_} ? $row->{$_} : NULL } @columns; for example, if we are going to use all column names in one prepare(). (do not like this) What about entries for many tables in a file? Note: I like your idea, simply don't know how to solve it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- What about the following structure: table_name: translatable: [ A, B ] fields [ A, B, C, D ] rows: - A: 1 B: 2 - A: 1 C: 2 D: 4 - A: 5 - B: 6 - C: 7 - D: 8 I do not think we should force to have the same number of fields. What if you want the default value for instance? That's not a big deal but I would prefer to get rid of this limitation since the beginning :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #28 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Jonathan, thanks to change Bug description, planned to do it today :) (In reply to Jonathan Druart from comment #26) > I am all good with it, we could improve (performance) later (like one INSERT > per file) if needed. Ok > Another improvement would be to move the .txt file into the YAML. I thought about that too, which would allow it to be translated as well. I will add the content in a description field. > I would like to see the translator tool ready before we push this one. Did > you investigate already the work that needs to be done? Yes... for xml :) I will work on this in Bug 24262 > I think we should move the already translated strings into a new .po (one > .po for all installer files?) I agree, perhaps 'xx-YY-installer.po' for common files, and append marcflavor content for MARC21/UNIMARC/NORMARC to existing files, or add new ones. > I can have a look if you did not already, but prefer to avoid duplication of > work :) Thanks! I'll try to solve this and let you know. Now some questions: 1) Bug 22824 - This patch can work indistinctly with YAML, YAML::Syck or YAML::XS, no problem with that. 2) YAML format: I'm using --- table: translatable: { A: 1 } rows: - A: 1 B: 2 - A: 3 B: 4 With this format we have only one table per file, and all rows must have the same number of values ( required by prepare($query) ) If we define things like --- - firstTable: translatable: { A: 1 } rows: - A1: 1 B1: 2 - A2: 1 B2: 2 - firstTable: translatable: { A: 1 } rows: - A: 1 B: 2 C: 3 - A: 4 B: 5 C: 6 - secondTable: translatable: { G: 1 } rows: - F: 1 G: 2 - F: 3 G: 4 we can have entries for the same table with different number of values, and also entries for different tables inserted in order. (BTW, of current installer sql files: 30 just one table, 9 more than one table; common+en files ) A change in format needs a simple revision of the code, but I would like some opinions about the format. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24263 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 [Bug 24263] borrowers.relationship should not contain an empty string -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #197 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- >From this commit 70651422a7517338a68e22321d9918757746ef33 Bug 14385: (QA follow-up) Additional changes and fixes @ Biblio.pm:1551 @ sub GetAuthorisedValueDesc { #---- branch if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "branches" ) { - return Koha::Libraries->find($value)->branchname; + my $branch = Koha::Libraries->find($value); + return $branch? $branch->branchname: q{}; } We are actually hiding a data inconsistency. I would recommend to revert that change and fix the failing test properly instead. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24148] New: black magic in Circulation/Returns.
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 Bug ID: 24148 Summary: black magic in Circulation/Returns. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On the newly created job Koha_Master_D9_MDB_Latest: koha_1 | # Looks like you planned 2 tests but ran 1. koha_1 | koha_1 | # Failed test 'AddReturn logging on statistics table (item-level_itypes=0)' koha_1 | # at t/db_dependent/Circulation/Returns.t line 249. koha_1 | Can't call method "itemtype" on an undefined value at t/db_dependent/Circulation/Returns.t line 247. I recreate locally with this configuration (latest MariaDB version), and tried to debug: modified: t/db_dependent/Circulation/Returns.t @ Returns.t:245 @ subtest "AddReturn logging on statistics table (item-level_itypes=0)" => sub { branch => $branch, type => 'return', itemnumber => $item_without_itemtype->{ itemnumber } - }, { order_by => { -asc => 'datetime' } })->next(); + }, { order_by => { -asc => 'datetime' } }); + warn $stat->count; + $stat = $stat->next; is( $stat->itemtype, $blevel_itemtype, "biblio-level itype recorded on statistics for return"); }; subtest 'Handle ids duplication' => sub { Guess what? ->count returns 1 but ->next returns undef! -- You are receiving this mail because: You are watching all bug changes.

1 8