December 2019 - Koha-bugs - lists.koha-community.org

[Bug 24248] New: The maximum allowable reduction of an accountline should use the combined refunded value
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24248 Bug ID: 24248 Summary: The maximum allowable reduction of an accountline should use the combined refunded value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Bug 23442 introduces a method of applying a discount/refund to an accountline debt and it enforces that a refund may not exceed the original amount owed on the accountline. However, there's nothing to prevent multiple refunds/discounts being applied to the same line and as such the combined total for all refund against that line should be used to prevent refunding more than the original owed amount instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #58 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 96384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96384&action=ed… Bug 7882: (follow-up) Only show sortable icon for sortable tags Only tags which can be repeated can be sorted, so the "bars" icon should not display by these tags. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #24 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- OK, that's lovely.. super simple to understand and write.. nice work Bernardo! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Store account offsets
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 [Bug 15985] Include transacting library in fines -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Looks great to me! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Great to have so many comment :) (In reply to David Cook from comment #12) > > Since this is installer data, I don't think it necessarily has to be fast? I > figure the most important part is to make it easy to read and update? Agreed, I think it's worth it > Actually, I don't know if we necessarily need to change C4/Installer.pm? > > We could use YAML as a declarative format for the database data, and then > the Release Manager/Release Maintainer could run a tool to compile it into a > SQL script. I think, as Katrin and Jonathan, that it's better not to compile sql, just use the files, then a change in C4/Installer.pm is needed. (In reply to Jonathan Druart from comment #16) > > > Why not write our own stuff, yml-based? > ... > I would: > - Retrieve and parse the whole YAML file > - Generate the SQL queries (like 1 per table) > - Execute the INSERT statements (using DBIx::RunSQL->run_sql) In the new patch I'm inserting directly. We can try to measure the delay, if any (In reply to Katrin Fischer from comment #18) > > Going back to the actual problem this patchset is trying to resolve.. can > > you remind me what it is about the SQL format files in the first place means > > we can't easily support translating them without moving to some intermediary > > file format? > > I think the problem is that you can't 'mark' what needs translation. You > only want to translate a small bit of the SQL files, the descriptions while > preventing people to translate values that should not be changed. Katrin is right, I couldn't find a general way to parse sql files to extract/replace strings. There are too many variations. The only one I'd made is the one used to generate translated frameworks, in translation server, that has different functions to extract/replace strings with 1,2,6,15,16 commas (,); and that after massaging EN frameworks sql files so they are exactly as expected. (In reply to Martin Renvoize from comment #20) > What I wasn't fully understanding is why we needed to move from a lots of > SQL files to one YAML/XML/Whatever file instead of a single SQL file which > gets translated via the tools. > > Sounds like SQL is just too hard to parse as is for the existing translation > tools.. that's the answer. It is hard, at last for me :( Thank you all! If you can, please take a look at the second patch. It uses YAML instead of XML, it's easier to read. I tried it and works. Do not install the first patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 96370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96370&action=ed… Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. Expected differences: most rows now have 'lib_opac' field with the same value as 'lib' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #57 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Owen Leonard from comment #55) > even though this isn't working correctly for me You're right Jonathan, tester error. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24253] New: process_message_queue.pl fail if not to address is defined
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24253 Bug ID: 24253 Summary: process_message_queue.pl fail if not to address is defined Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: hagud(a)orex.es QA Contact: testopia(a)bugs.koha-community.org Koha 18.11.x the cronjob process_message_queue.pl fails if any notice has not to_email_address. Test plan: Set up a user without email address configure notes for item check in and item checkout (or any other notice) you won't receive any email because there is no to_address possible solution a default address if no email defined at user account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 24216] New: kohastructure.sql uses BOOLEANs
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24216 Bug ID: 24216 Summary: kohastructure.sql uses BOOLEANs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org kohastructure.sql uses both BOOLEAN and tinyint(1) for boolean values. The existing booleans should be converted to tinyints, as per the coding guidelines https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1