December 2019 - Koha-bugs - lists.koha-community.org

[Bug 16688] New: RenewSerialAddsSuggestion - suggestions not showing up, note not saved
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16688 Bug ID: 16688 Summary: RenewSerialAddsSuggestion - suggestions not showing up, note not saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When renewing a serial subscription with RenewSerialAddsSuggestion set to active, an entry is added to the suggestions table in Koha. The status is "ASKED" and the biblionumber is column is set to the existing record. But the suggestion isn't shown in the acquisition module - it cannot be found using the search options in suggestions, it doesn't show in the pending tab. Because the status is "ASKED", there is no way to create an order for it. When renewing the subscription, there is a note field you can fill out "for the librarian to process the order" - but this information is not stored in suggestion table and seems to be lost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 7047] Renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- *** Bug 16688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7047] Renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Depends on| |24244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 [Bug 24244] Cannot create suggestion with branch set to 'Any' -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7047] Renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96311&action=ed… Bug 7047: Revert changes relative to the new column on suggestion list We should move that to its own bug report if needed, not sure we will all agree on that new column. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7047] Renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96310&action=ed… Bug 7047: Change ReNewSubscription prototype - use hashref It also removes a warn statement. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7047] Renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72639|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96309&action=ed… Bug 7047: Storing subscription renewal note in suggestion to be displayed on the suggestion page. Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription. Test plan: 1. Create a subscription (if one does not already exist) 2. Set the RenewSerialAddsSuggestion syspref to 'Add' 3. Renew the item making sure to write in a value into the note field 3. Visit the suggestions page and notice that the note is not displayed for the newly created suggestion 4. Apply patch 5. Repeat step 3. Notice that there is now a new branchcode dropdown box. Select one of your libraries and write in the value into the note field 6. Visit suggestions and notice there is now a 'Suggestion note' column in the table containing the note. Also note that the suggestion has the correct branchcode associated with it Sponsored-By: Catalyst IT Signed-off-by: Maksim Sen <maksim(a)inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7047] Renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12814] Authority cataloging problem
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12814 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Resolution|--- |FIXED --- Comment #2 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I do not longer recreate the problem. I am closing it for now, please reopen if it is still valid. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5334] Omnibus: Add explicit foreign key constraints
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Bug 5334 depends on bug 17160, which changed state. Bug 17160 Summary: Foreign key constraint for message_transports is too loose https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 17160] New: Foreign key constraint for message_transports is too loose
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160 Bug ID: 17160 Summary: Foreign key constraint for message_transports is too loose Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I think this is the probable cause for Bug 13171. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/my… The message transports definition -- -- Table structure for table `message_transports` -- DROP TABLE IF EXISTS `message_transports`; CREATE TABLE `message_transports` ( `message_attribute_id` int(11) NOT NULL, `message_transport_type` varchar(20) NOT NULL, `is_digest` tinyint(1) NOT NULL default '0', `letter_module` varchar(20) NOT NULL default '', `letter_code` varchar(20) NOT NULL default '', `branchcode` varchar(10) NOT NULL default '', PRIMARY KEY (`message_attribute_id`,`message_transport_type`,`is_digest`), KEY `message_transport_type` (`message_transport_type`), KEY `letter_module` (`letter_module`,`letter_code`), CONSTRAINT `message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `message_transports_ibfk_2` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`, `letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`, `branchcode`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; Has `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`, `letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`, `branchcode`) ON DELETE CASCADE ON UPDATE CASCADE The foreign key contstraints `module`, `code`, `branchcode` do *NOT* uniquely identify a row in the letter table, because message_transport_type may vary. Therefore, a deletion *any* message transport type will delete *all* rows matching `module`, `code`, `branchcode`. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7