December 2019 - Koha-bugs - lists.koha-community.org

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94837|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96344&action=ed… Bug 7882: Add ability to move and reorder fields in MARC editor Use jQueryUI sortable to make fields and subfields moveable in the MARC editor for both records and authorities. This patch convert items from div's to ul's and consequently alter css and js to match. It also replace the up arrow with a more adapted icon (from font awesome). Primary authorship by Elliott Davis. To Test: 1. Add or edit a record in cataloguing module. 2. You should be able to move the fields and subfields around. - You can click on any part of the element to drag it, the move icon to the left of the item is a good place to do it. => You can only change the order of fields of the same tag. 3. Make sure all of the javascript driven fonctionnality still work : - Duplicate fields/subfields - Remove fields/subfields - Using the tag editor for control fields or to link authorities - etc 4. Reorder some fields/subfields and save the record. 5. Edit the record again. 6. The order in the editor should match the changes which were saved. - Empty subfields should appear after the ones with content. 7. Repeat steps 1-6 with the authority editor. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #49) > This is working great! > > 2 smalls things: > - required fields (the subfield's lib) are red > https://snipboard.io/CMuDYp.jpg > Is that expected? Sorry, that is coming from bug 24090. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #49 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- This is working great! 2 smalls things: - required fields (the subfield's lib) are red https://snipboard.io/CMuDYp.jpg Is that expected? - Do we really need the sort icon for each subfield? And, not blocker for this bug report (regarding its age), but we could remove the "sortable" option for fields that cannot be duplicated for instance. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10352] Cataloguing log search mixing itemnumber/bibnumber
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96273|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96336&action=ed… Bug 10352: Get add operations too When an add for biblio or item is recorded there is no space in the info field Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96261|0 |1 is obsolete| | --- Comment #60 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96331&action=ed… Bug 14973: Fix edit a suggestion and dup found The find duplicate call must only be done when the suggestion is new. It does not make sense to search for a duplicate when the suggestion already exists. This patch also fixes a side-effect: - Create a suggestion using an existing biblio title - Ignore the warning and save - Edit again and save => BOOM on date Template process failed: undef error - The given date (18/11/2019) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 168 The dates are not processed and so badly formatted when sent to the template. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96260|0 |1 is obsolete| | --- Comment #59 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96330&action=ed… Bug 14973: Add missing filters in templates Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96259|0 |1 is obsolete| | --- Comment #58 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96329&action=ed… Bug 14973: Remove double declaration of suggestions_loop Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96258|0 |1 is obsolete| | --- Comment #57 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96328&action=ed… Bug 14973: Remove double textarea for notes Certainly a bad merge conflict resolution (I am certainly the one to blame). However I do not understand where this "note" variable come from. Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96257|0 |1 is obsolete| | --- Comment #56 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96327&action=ed… Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0