February 2019 - Koha-bugs - lists.koha-community.org

[Bug 16300] New: Remove the use of "onclick" from circulation and fine rules template
by bugzilla-daemon＠bugs.koha-community.org 02 May '19

02 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Bug ID: 16300 Summary: Remove the use of "onclick" from circulation and fine rules template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/smart-rules.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, testopia(a)bugs.koha-community.org, veron(a)veron.ch Depends on: 15456 There is one place where an "onclick" attribute is used in admin/smart-rules.tt. It should be rewritten so that JS functionality is separate from the markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 22268] New: Data displayed in request list datatable is not sanitized
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 Bug ID: 22268 Summary: Data displayed in request list datatable is not sanitized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Target Milestone: --- Request data displayed in the "Request view" or similar views is sanitized by the html filter in the template. However, the main request list table is generated via Datatables and is not sanitized. This can be demonstrated by entering a malicious string, such as: <script>alert('pwned');</script> Into the request notes field, then displaying the requests table. I've not yet investigated if column data that is generated via render functions is affected, or whether it's just the columns that are passed through by Datatables. Investigate how this has been addressed elsewhere in Koha. Also, possible mitigations can be seen here: https://datatables.net/manual/security -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 19575] New: Use canonical field names and resolve aliased fields
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Bug ID: 19575 Summary: Use canonical field names and resolve aliased fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com The current elastic search fields seems to be a mix between zebra aliases, field names, some duplicates and new fields. This causes issues with sorting in UI and hard-coded search-links in XSL-templates for example. I have attempted to clean things up a bit, which resolves many of these issues. I might not have the time to do so today, but will attempt to find and mark all current issues resolved by this fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 122

[Bug 22219] New: C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Bug ID: 22219 Summary: C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- The SQL does a left join to reserves ON (itemnumber) If there are multiple item-specific holds we will get multiple results for a biblio Discovered while running tests on bug 21798 To recreate: 1 - place several holds on a specific item 2 - prove -v t/db_dependent/Items/GetItemsForInventory 3 - It fails -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 22392] New: TestBuilder::build_sample_item should allow defining barcode
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22392 Bug ID: 22392 Summary: TestBuilder::build_sample_item should allow defining barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Currently, build_sample_item is hardcoded to always produce a random barcode.. for acquisitions tests we may wish to define a barcode or even ensure we can pass an undefined one. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 21971] New: TestBuilder::gimme_an_item
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Bug ID: 21971 Summary: TestBuilder::gimme_an_item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 21816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816 [Bug 21816] [OMNIBUS] Ease the write of our tests -- You are receiving this mail because: You are watching all bug changes.

1 32

[Bug 21622] New: Incorrect GROUP BY clause in acqui/ scripts
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Bug ID: 21622 Summary: Incorrect GROUP BY clause in acqui/ scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 17258 acqui/ordered.pl: GROUP BY aqorders.ordernumber acqui/spent.pl: GROUP BY aqorders.ordernumber 'koha_kohadev.aqorders.biblionumber' isn't in GROUP BY Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 35

[Bug 20535] New: ModZebra called with $record with items stripped in ModBiblioMarc
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Bug ID: 20535 Summary: ModZebra called with $record with items stripped in ModBiblioMarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com The record that get passed to ModBiblioMarc will not have items embedded. Saving this through ModZebra will create an elastic document without items, and no items will be shown in search results for example. By removing the $record argument from the ModZebra call, ModZebra will reload the record with items embedded, which solves the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 21998] New: Add pattern parameter in Koha::Token
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Bug ID: 21998 Summary: Add pattern parameter in Koha::Token Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Split from bug 21336 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 21948] New: Clean up style of item detail page
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Bug ID: 21948 Summary: Clean up style of item detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 21304 Blocks: 20654 There are some page-specific styles for the item detail page which can be removed. This patch will add some markup to the page to trigger the more generally-used style. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 [Bug 21304] Update two-column templates with Bootstrap grid: Catalog -- You are receiving this mail because: You are watching all bug changes.

1 20