February 2019 - Koha-bugs - lists.koha-community.org

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #106 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 85851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85851&action=ed… Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83696|0 |1 is obsolete| | Attachment #83697|0 |1 is obsolete| | Attachment #83698|0 |1 is obsolete| | Attachment #85406|0 |1 is obsolete| | --- Comment #105 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 85850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85850&action=ed… Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #24 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Hello Katrin, you're right. I have to buy a new brain. I've begun my tests with the right logic and I don't know why, I swapped... Jonathan, before redoing the tests,I'm not sure we are on the same logic for the case "1 day of suspension every 2 days (finedays = 1, suspension_chargeperiod = 2)" - 20 days late => 10 days of suspension : OK - 1 day late => 1 day of suspension (was 2 before the last patch) -> Should we begin to add charge before 2 days late ? I would say : * 1 day late => 0 day of suspension (was 2 before the last patch) * 2 days late => 1 day of suspension - 2 hours late => 1 day of suspension (was 2 before the last patch) The same here * 2 hours late => 0 day of suspension (was 2 before the last patch) * 2 hours late + 1 day => 1 day of supension - 2 hours before => 0 day of suspension : OK In my opinion, if suspension_chargeperiod = 2, we should not charge on the first day... but, I'm not sure of the behaviour in the current version of Koha. Other opinions on that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #23 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Hello Katrin, you're right. I have to buy a new brain. I've begun my tests with the right logic and I don't know why, I swapped... Jonathan, before redoing the tests,I'm not sure we are on the same logic for the case "1 day of suspension every 2 days (finedays = 1, suspension_chargeperiod = 2)" - 20 days late => 10 days of suspension : OK - 1 day late => 1 day of suspension (was 2 before the last patch) -> Should we begin to add charge before 2 days late ? I would say : - 1 day late => 0 day of suspension (was 2 before the last patch) - 2 days late => 1 day of suspension - 2 hours late => 1 day of suspension (was 2 before the last patch) - 2 hours before => 0 day of suspension -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #104 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, Nick, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11969] Show patrons star rating on their reading history
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20985 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13829] Syntax highlighter on source code textareas
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13829 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- We might be able to use Codemirror now for those as it's being used for the SQL reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12978] Make files attached to patron record optionally available to patrons
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '19

28 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12978 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Files attached to patron |Make files attached to |record. |patron record optionally | |available to patrons CC| |katrin.fischer(a)bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

1 0