February 2019 - Koha-bugs - lists.koha-community.org

[Bug 11063] Add circulation message's patron when checkin items (returns.pl)
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11063 --- Comment #3 from Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> --- (In reply to Lisette Scheer from comment #2) > Circulation notes do show in "Notes" column so I believe this has been > fixed. > Lisette Yes it's ok! Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 22425] New: Icons directory broken on OPAC interface
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22425 Bug ID: 22425 Summary: Icons directory broken on OPAC interface Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: dpk(a)randomnotes.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Version: 18.11.03 (just upgraded) OPAC theme: bootstrap OPAC Fallback theme: prog After upgrading to 18.11.03 using the debian packages on February 25th, we noticed the icons on search results were broken (the image did not load). Search results in the admin interface displayed properly. Looking at the image reference in the HTML, I found the file reference went and looked at the filesystem. As an example, the book icon was supposed to be: <img src="/opac-tmpl/lib/famfamfam/silk/book.png" alt="book" title="book" class="materialtype"> The broken OPAC directory has no silk subdirectory and the only book appears to be book_previous.png which suggests this directory was in the midst of manipulation when the package was built: /usr/share/koha/opac/htdocs/opac-tmpl/lib/famfamfam: total 176 drwxr-xr-x 2 root root 4096 Feb 25 10:22 . drwxr-xr-x 5 root root 4096 Jun 11 2018 .. -rw-r--r-- 1 root root 622 Feb 25 03:24 AR.png -rw-r--r-- 1 root root 345 Feb 25 03:24 arrow_left.png -rw-r--r-- 1 root root 685 Feb 25 03:24 arrow_refresh.png -rw-r--r-- 1 root root 593 Feb 25 03:24 BK.png -rw-r--r-- 1 root root 680 Feb 25 03:24 book_previous.png -rw-r--r-- 1 root root 675 Feb 25 03:24 calendar.png -rw-r--r-- 1 root root 587 Feb 25 03:24 cancel.png -rw-r--r-- 1 root root 673 Feb 25 03:24 cd.png -rw-r--r-- 1 root root 620 Feb 25 03:24 CF.png -rw-r--r-- 1 root root 710 Feb 25 03:24 chart_curve.png -rw-r--r-- 1 root root 666 Feb 25 03:24 controller.png -rw-r--r-- 1 root root 655 Feb 25 03:24 cross.png -rw-r--r-- 1 root root 390 Feb 25 03:24 database.png -rw-r--r-- 1 root root 686 Feb 25 03:24 drive_web.png -rw-r--r-- 1 root root 764 Feb 25 03:24 dvd.png -rw-r--r-- 1 root root 567 Feb 25 03:24 font.png -rw-r--r-- 1 root root 606 Feb 25 03:24 GR.png -rw-r--r-- 1 root root 786 Feb 25 03:24 help.png -rw-r--r-- 1 root root 343 Feb 25 03:24 link.png -rw-r--r-- 1 root root 615 Feb 25 03:24 magnifier.png -rw-r--r-- 1 root root 760 Feb 25 03:24 MM.png -rw-r--r-- 1 root root 804 Feb 25 03:24 MP.png -rw-r--r-- 1 root root 610 Feb 25 03:24 MU.png -rw-r--r-- 1 root root 760 Feb 25 03:24 MX.png -rw-r--r-- 1 root root 500 Feb 25 03:24 note.png -rw-r--r-- 1 root root 825 Feb 25 03:24 OB.png -rw-r--r-- 1 root root 548 Feb 25 03:24 paintbrush.png -rw-r--r-- 1 root root 450 Feb 25 03:24 pencil.png -rw-r--r-- 1 root root 704 Feb 25 03:24 pictures.png -rw-r--r-- 1 root root 385 Feb 25 03:24 PR.png -rw-r--r-- 1 root root 53 Feb 25 03:24 readme.txt -rw-r--r-- 1 root root 649 Feb 25 03:24 report.png -rw-r--r-- 1 root root 748 Feb 25 03:24 script.png -rw-r--r-- 1 root root 658 Feb 25 03:24 SE.png -rw-r--r-- 1 root root 700 Feb 25 03:24 stop.png -rw-r--r-- 1 root root 789 Feb 25 03:24 ST.png -rw-r--r-- 1 root root 452 Feb 25 03:24 TD.png -rw-r--r-- 1 root root 344 Feb 25 03:24 text_list_bullets.png -rw-r--r-- 1 root root 741 Feb 25 03:24 user.png -rw-r--r-- 1 root root 653 Feb 25 03:24 VM.png -rw-r--r-- 1 root root 957 Feb 25 03:24 world_link.png -rw-r--r-- 1 root root 923 Feb 25 03:24 world.png The working Admin interface has a different directory content: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/img/famfamfam/: total 64 drwxr-xr-x 3 root root 4096 Feb 25 10:22 . drwxr-xr-x 5 root root 4096 Feb 25 10:22 .. -rw-r--r-- 1 root root 622 Feb 25 03:24 AR.png -rw-r--r-- 1 root root 593 Feb 25 03:24 BK.png -rw-r--r-- 1 root root 620 Feb 25 03:24 CF.png -rw-r--r-- 1 root root 606 Feb 25 03:24 GR.png -rw-r--r-- 1 root root 760 Feb 25 03:24 MM.png -rw-r--r-- 1 root root 804 Feb 25 03:24 MP.png -rw-r--r-- 1 root root 610 Feb 25 03:24 MU.png -rw-r--r-- 1 root root 760 Feb 25 03:24 MX.png -rw-r--r-- 1 root root 385 Feb 25 03:24 PR.png -rw-r--r-- 1 root root 658 Feb 25 03:24 SE.png drwxr-xr-x 2 root root 4096 Feb 25 10:22 silk -rw-r--r-- 1 root root 789 Feb 25 03:24 ST.png -rw-r--r-- 1 root root 452 Feb 25 03:24 TD.png -rw-r--r-- 1 root root 653 Feb 25 03:24 VM.png /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/img/famfamfam/silk: total 72 drwxr-xr-x 2 root root 4096 Feb 25 10:22 . drwxr-xr-x 3 root root 4096 Feb 25 10:22 .. -rw-r--r-- 1 root root 789 Feb 25 03:24 book_link.png -rw-r--r-- 1 root root 622 Feb 25 03:24 book_open.png -rw-r--r-- 1 root root 593 Feb 25 03:24 book.png -rw-r--r-- 1 root root 675 Feb 25 03:24 calendar.png -rw-r--r-- 1 root root 792 Feb 25 03:24 computer_link.png -rw-r--r-- 1 root root 655 Feb 25 03:24 cross.png -rw-r--r-- 1 root root 666 Feb 25 03:24 error.png -rw-r--r-- 1 root root 653 Feb 25 03:24 film.png -rw-r--r-- 1 root root 804 Feb 25 03:24 map.png -rw-r--r-- 1 root root 385 Feb 25 03:24 music.png -rw-r--r-- 1 root root 658 Feb 25 03:24 newspaper.png -rw-r--r-- 1 root root 591 Feb 25 03:24 page_white_acrobat.png -rw-r--r-- 1 root root 603 Feb 25 03:24 page_white_code.png -rw-r--r-- 1 root root 663 Feb 25 03:24 page_white_excel.png -rw-r--r-- 1 root root 760 Feb 25 03:24 report_disk.png -rw-r--r-- 1 root root 610 Feb 25 03:24 sound.png -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 14708] The patron set as the anonymous patron should not be deletable.
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Hi Kyle, At first glance I'd say tools/cleanborrowers.pl is missing. Maybe we should have this constraint in Koha::Patron->delete/move_to_deleted to make sure we are covering all cases? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- My tests cover the following situations: * 2 days of suspension every day (finedays = 2, suspension_chargeperiod = 1) - 20 days late => 40 days of suspension - 1 day late => 2 days of suspension - 2 hours late => 2 days of suspension - 2 hours before => 0 day of suspension * 1 day of suspension every 2 days (finedays = 1, suspension_chargeperiod = 2) - 20 days late => 10 days of suspension - 1 day late => 1 day of suspension (was 2 before the last patch) - 2 hours late => 1 day of suspension (was 2 before the last patch) - 2 hours before => 0 day of suspension -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable.
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #4 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 85789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85789&action=ed… Bug 14708: Enforce restriction in delete_patrons.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #21 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 85788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85788&action=ed… Bug 14293: Add more tests and fix floor/ceil -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Could you please list the different situations you have tested (circulation rules values) then what you would have expected and what you get? With OK and NOK in front of each cases. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #266 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased + squashed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80980|0 |1 is obsolete| | Attachment #80981|0 |1 is obsolete| | Attachment #80982|0 |1 is obsolete| | --- Comment #265 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 85787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85787&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed 5. prove t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '19

27 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80979|0 |1 is obsolete| | --- Comment #264 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 85786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85786&action=ed… Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0