February 2019 - Koha-bugs - lists.koha-community.org

[Bug 21691] New: Koha::Account->non_issues_charges has no tests
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691 Bug ID: 21691 Summary: Koha::Account->non_issues_charges has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Everything in the Koha namespace should be properly tested.. but Koha::Account has a number of methods that are missing corresponding tests. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #27 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Back to signed off now I've added the required update to the tests (and also added a db update to make old cardnumber logs match the new format.. although we can't retrospectively populate the logs for other actions the update should make writing future reports backwards compatible without adding effort. Let me know if you'd like any further additions to the tests or anything. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #26 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85246&action=ed… Bug 3820: Update tests to reflect the change of behaviour -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #25 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85245&action=ed… Bug 3820: DB Update to make old cardnumber logs match the new format -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85197|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85244&action=ed… Bug 3820: (follow-up) Clean up warnings Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Charles Farmer <charles.farmer(a)inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85196|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85243&action=ed… Bug 3820: Add changes to MEMBERS MODIFY logaction This patch attemps to add a more refined and detailed info structure detailing what fields were changed and what they were changed from and to. Test Plan: Enable BorrowersLog in the system preferences and undertake a series of borrower detail changes. Go to view the actionlogs and note that MEMBER MODIFY logs now detail what fields you have changed using the following form: { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } } Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Charles Farmer <charles.farmer(a)inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22327] New: Circulation Rules simplification
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22327 Bug ID: 22327 Summary: Circulation Rules simplification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- What if the rules table was a condensed summary table, linkable to a modal that opened up with options for the rule that is clicked? Would also like to see the ability to test rules out by plugging in variables and see what rule runs with it. This would help greatly in troubleshooting the rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com Status|Signed Off |Failed QA QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | --- Comment #22 from Josef Moravec <josef.moravec(a)gmail.com> --- This is great addition and I like it, but as it changes the behaviour, the test should be adjusted too: t/db_dependent/Koha/Patrons.t .. 29/33 # Failed test 'Got correct new cardnumber' # at t/db_dependent/Koha/Patrons.t line 1414. # got: undef # expected: 'TESTCARDNUMBER' # Failed test 'Got correct old cardnumber' # at t/db_dependent/Koha/Patrons.t line 1415. # got: undef # expected: 'jY44Hy2e7OojC2Zx7vMo43gzub' # Failed test 'With BorrowerLogs, Change in cardnumber should be logged, as well as general alert of patron mod.' # at t/db_dependent/Koha/Patrons.t line 1416. # got: '1' # expected: '2' # Looks like you failed 3 tests of 3. # Failed test 'Log cardnumber change' # at t/db_dependent/Koha/Patrons.t line 1417. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #2 from David Cook <dcook(a)prosentient.com.au> --- I noticed recently that "lastseen" updates for "Patron logs into OPAC" and "Patron is authenticated via SIP2" and that's it. I've had libraries interested in the field being updated for the other activities Nicole mentioned as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0