February 2019 - Koha-bugs - lists.koha-community.org

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #12 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Meh, guess I broke up something while trying to sign the patches, only one of them is signed and I cannot apply the patches anymore using git-bz... I wonder what I screwed up here :/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21976 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21976 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 [Bug 21976] koha-reset-passwd does not deal with password restrictions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #163 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #162) > From the test plan, I don't get how «test mode for notices so a library can > see what all of the notices will look like before go live» (from the > description) > > Can we trigger emails without the queue being consumed? > > i.e. What would be the workflow to use this feature to go back and forth > between tuning the notices and seeing the result. They are still send the same way (via the queue if they normally are), but to another email address that you specified. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset(a)biblibre.co | |m --- Comment #162 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- >From the test plan, I don't get how «test mode for notices so a library can see what all of the notices will look like before go live» (from the description) Can we trigger emails without the queue being consumed? i.e. What would be the workflow to use this feature to go back and forth between tuning the notices and seeing the result. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85251|0 |1 is obsolete| | --- Comment #11 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 85252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85252&action=ed… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: Nick Clemens <nick(a)quecheelibrary.org> Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85210|0 |1 is obsolete| | --- Comment #10 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 85251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85251&action=ed… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: Nick Clemens <nick(a)quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #9 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- This new patch do suspend the user until next day from the first minute overdue up until 24h late (non-inclusive). Then suspends for one more day for each period of 24h overdue. IMHO it is quite fair that one who is overdue for the night and brings back yesterday's hourly loans on the next morning may not borrow new books on the same day. If someone take a hourly loan and only brings back the book on the next morning then one might not get suspended for let say 10 days if one is 10 periods of 1h overdue. This behaviour is same whatever the hourly loan period is (tried with 1h and 6h), which I guess is the expected/desired behaviour. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21691] New: Koha::Account->non_issues_charges has no tests
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691 Bug ID: 21691 Summary: Koha::Account->non_issues_charges has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Everything in the Koha namespace should be properly tested.. but Koha::Account has a number of methods that are missing corresponding tests. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #27 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Back to signed off now I've added the required update to the tests (and also added a db update to make old cardnumber logs match the new format.. although we can't retrospectively populate the logs for other actions the update should make writing future reports backwards compatible without adding effort. Let me know if you'd like any further additions to the tests or anything. -- You are receiving this mail because: You are watching all bug changes.

1 0