February 2019 - Koha-bugs - lists.koha-community.org

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- What about generate a password if none is provided? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16714] New: Unexpected logout with "IP address change"
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 Bug ID: 16714 Summary: Unexpected logout with "IP address change" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org I get a new issue (not sure since when) under Plack: I am logged out with "IP address change" just after the first login. To reproduce: - logout - restart plack - login - click somewhere => You will be logged out I have tried to debug: diff --git a/C4/Auth.pm b/C4/Auth.pm index 985bd39..a494ddf 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -818,6 +818,9 @@ sub checkauth { $userid = $s_userid; $sessiontype = $session->param('sessiontype') || ''; } + + warn $ip; + warn $ENV{REMOTE_ADDR}; if ( ( $query->param('koha_login_context') && ( $q_userid ne $s_userid ) ) || ( $cas && $query->param('ticket') && !C4::Context->userenv->{'id'} ) || ( $shib && $shib_login && !$logout && !C4::Context->userenv->{'id'} ) I get: After the login: $ip=undef, $ENV{REMOTE_ADDR}=192.168.254.1 After the click producing the logout: $ip=192.168.254.1, $ENV{REMOTE_ADDR}=127.0.0.1 After the second login: $ip=127.0.0.1, $ENV{REMOTE_ADDR}=127.0.0.1 -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 14525] undo checkin/out when accompanying message appears
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |joy(a)bywatersolutions.com --- Comment #3 from Joy Nelson <joy(a)bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 17101 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |maryse.simard(a)inlibro.com --- Comment #10 from Maryse Simard <maryse.simard(a)inlibro.com> --- Patch doesn't apply Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14866: Make high holds work with different item types .git/rebase-apply/patch:88: space before tab in indent. </tr> .git/rebase-apply/patch:89: space before tab in indent. [% END %] warning: 2 lines add whitespace errors. Using index info to reconstruct a base tree... M C4/Circulation.pm M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt .git/rebase-apply/patch:88: space before tab in indent. </tr> .git/rebase-apply/patch:89: space before tab in indent. [% END %] warning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging admin/smart-rules.pl CONFLICT (content): Merge conflict in admin/smart-rules.pl Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14866: Make high holds work with different item types -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21363] New: Unwanted margin between checkout form and last checked out information
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21363 Bug ID: 21363 Summary: Unwanted margin between checkout form and last checked out information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19474 Created attachment 78992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78992&action=ed… Screenshot showing the problem Probably caused by Bug 19474. See attached screenshot. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85160|0 |1 is obsolete| | --- Comment #445 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 85198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85198&action=ed… Bug 7143: (follow-up) Update about page for new devs (Academy) It's now 2019! Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0