February 2019 - Koha-bugs - lists.koha-community.org

[Bug 19957] New: Allow continued editing after saving a report
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Bug ID: 19957 Summary: Allow continued editing after saving a report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard(a)inlibro.com Depends on|11140 | --- Comment #161 from Maryse Simard <maryse.simard(a)inlibro.com> --- I have rebased the patches because I was getting conflicts in installer/data/mysql/sysprefs.sql. Concerning comment #154 > 1 - Is dependency on 11140 relevant? I don't suppose it is needed anymore, so I've removed it. > 2 - As far as I can tell this will never update the message_queue to reflect > where the message was sent - can this be done? The mail logs would reflect > the truth, but it feels like this is not optimal I added a patch to take care of updating the message queue with the to address used. > Blocker: > 1 - Message is only redirected if email in pref is valid, however, the email > is not validated at entry - a typo could cause the redirection to fail My last patch adds validation to the system preferences page making sure the entered email is valid. That way, the redirection should not fail because of an invalid email. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140 [Bug 11140] Centralize all sending of email to one subroutine -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11140] Centralize all sending of email to one subroutine
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8000 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 [Bug 8000] Test mode for notices -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #160 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 84805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84805&action=ed… Bug 8000: (QA follow-up) Add email validation to system preferences This patch uses the JQuery validator plugin to add validation to preferences of class email in the system preferences page. A field containing an invalid value (even if not modified) should prevent saving. To test, confirm that when entering an invalid email address in the SendAllEmailsTo field, an error message appears and saving is prevented. Correcting the value should hide the message and let you save as normal. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #159 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 84804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84804&action=ed… Bug 8000: (QA follow-up) Update the to_address in the message queue -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81591|0 |1 is obsolete| | --- Comment #158 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 84803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84803&action=ed… Bug 8000: (QA follow-up) Fix accidently edited sysprefs.sql file Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81590|0 |1 is obsolete| | --- Comment #157 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 84802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84802&action=ed… Bug 8000: (QA follow-up) Centralise Bcc too Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '19

06 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81589|0 |1 is obsolete| | --- Comment #156 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 84801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84801&action=ed… Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21993] New: Be userfriendly when the CSRF token is wrong
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '19

05 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993 Bug ID: 21993 Summary: Be userfriendly when the CSRF token is wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org We can use output_and_exit (with blocking_errors.inc) to handle this case in a user friendly manner. -- You are receiving this mail because: You are watching all bug changes.

1 14