February 2019 - Koha-bugs - lists.koha-community.org

[Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #78 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, you can usually set back to "Signed off" after a rebase if it was before (unless you feel the changes were too heavy and should be retested) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21447] New: Inventory lists incorrectly sorted
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 Bug ID: 21447 Summary: Inventory lists incorrectly sorted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org In the real world, I've found the cn_sort field does not always have correct values, and the same itemcallnumber field may have different cn_sort values. My theory is that the method for generating cn_sort changed at some point, and that has created inconsistencies in the creation of cn_sort value, especially in Koha databases that have existed for a long period of time. -- I received reports that the lists generated by /cgi-bin/koha/tools/inventory.pl and shown on screen weren't sorted by call number. That led me to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021 and that seemed to solve the problem as it resorted the data table by the call number. However, when using the "Export to CSV file" option, the data was still not sorted correctly, and thus was incompatible with the data table shown on screen, which defeats the purpose of doing an inventory without a scanned barcode file. -- This can be solved by running touch_all_items.pl. However, this is not a systematic solution. Perhaps we should do a database revision that runs ModItem for all items. This seems problematic for databases with large numbers of items, but it seems a good idea to provide a systematic solution instead of requiring people to run touch_all_items.pl if they notice the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #77 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Katrin Fischer from comment #66) > Conflicts in the Schema changes part (should be a separate patch) Can you > please fix and maybe separate these changes out? > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 15326: Add CMS feature > Applying: Bug 15326: (follow-up) Add CMS feature > Using index info to reconstruct a base tree... > M Koha/Schema/Result/Branch.pm > Falling back to patching base and 3-way merge... > Removing t/Pages.t > Auto-merging Koha/Schema/Result/Branch.pm > CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 15326: (follow-up) Add CMS feature > The copy of the patch that failed is found in: .git/rebase-apply/patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in /tmp/Bug-15326-follow-up-Add-CMS-feature-E4XbRe.patch Rebased and moved schema fixes into a separate patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #76 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 84691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84691&action=ed… Bug 15326: Schema changes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83412|0 |1 is obsolete| | --- Comment #75 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 84690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84690&action=ed… Bug 15326: (follow-up) Pages navigation fixes This is the best I've managed to do with the navigation. Would be happy for someone else to give it a go because I'm aware that some parent links repeat. Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83411|0 |1 is obsolete| | --- Comment #74 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 84689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84689&action=ed… Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83410|0 |1 is obsolete| | --- Comment #73 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 84688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84688&action=ed… Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '19

04 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83409|0 |1 is obsolete| | --- Comment #72 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 84687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84687&action=ed… Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0