February 2019 - Koha-bugs - lists.koha-community.org

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Nick, coming back to this: QA scripts pass now (good!) Am I right that this is ES only? But: 1) There is an issue with the CSS files (please fix first of all): $ node_modules/.bin/gulp build --view=opac [14:17:24] Using gulpfile ~/kohaclone/gulpfile.js [14:17:24] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Error: Invalid CSS after "... solid #E3E3E3;": expected "}", was ".border-radius-all(" on line 3281 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> border: 1px solid #E3E3E3; -----------------------------------^ 2) Please add the link to the navigation (formerly 1). I feel it would make sense to have this depending on a system preference as the other additional features in the navigation bar do. It should also note that this is for Elasticsearch only. But beware: We already got OpacBrowser and OpacBrowseReults... (probably OpacBrowser should be renamed OpacBrowseAuthorities...). 3) opac-browse.pl doesn't use the standard use CGI qw ( -utf8 ); 4) Follow-up bug or something to resolve before pushing? +# This is the temporary entrance point to the API. Once bug #13799 is settled, +# it should be ported to using that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #43 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jessie Zairo from comment #42) > It would be great if we could also add a feature to browse by call number. Hi Jesse, please file a separate bug for this depending on this one. Thx! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Number of items to order on |Number of items to order on |holds ratio report will not |holds ratio report will not |fulfill the holds ratio. |fulfill the holds ratio -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am with Jonathan on this one... it kind of screems for tests as they are practically written out in the bug and on the commit message. It will also help us to confirm in the future that this is the desired behaviour. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Tried to apply on top of patches for 21751, but got a conflict: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11375: Improve patrons permissions display error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 11375: Improve patrons permissions display The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11375-Improve-patrons-permissions-display-jTsU_R.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Passed QA on depenency, unlocking this one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #84 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 84654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84654&action=ed… Bug 11373: (follow-up) Add "change calculation" feature to the fine payment forms This patch provides some follow-ups, including corrections to the JavaScript and updates to the text for readability. - Remove obsolete script "type" attribute - Update the use of the obsolete jQuery method "bind" - Use Bootstrap's built-in "show" option instead of simulated click - Handle preventDoubleFormSubmit function's "waiting" class if modal is closed manually To test, apply the patch and follow the original test plan. Everything should work as expected. Note that when the modal is shown, the cursor changes to the "waiting" one when you hover over the body of the page. If you click "No" in the modal, the cursor should return to normal. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83812|0 |1 is obsolete| | Attachment #83813|0 |1 is obsolete| | --- Comment #83 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 84653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84653&action=ed… Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid. Test plan : - Apply patch. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$). - Confirm that the change is correct (example : 5$ - 3$ = 2$). - Click the button confirm. - Click on Yes in the dialog box. - Confirm that the payment has been made (example : last amount = 3$). Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '19

02 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22047] New: set_password should have an 'unsafe' param
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '19

01 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Bug ID: 22047 Summary: set_password should have an 'unsafe' param Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- On removing traces of update_password in the codebase, I noticed the use case in Auth_with_ldap.pm which basically skips any password quality check. I'm not sure if that 'feature' is or should be used. For now, we should provide this alternate behaviour. The best approach is adding an 'unsafe' param. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 32