March 2019 - Koha-bugs - lists.koha-community.org

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #124 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87149&action=ed… Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find Test plan: 1) Apply all patches except this one 2) Checkout out an item to a patron 3) Check the item in - note that this will fail 4) Apply this patch, and repeat steps 1-3, noting instead that the the check is instead successful 5) Verify also that reserves act as expected 5) Sign off Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #123 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87148&action=ed… Bug 14576: Rebase fixes Fix test Rebase code Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #122 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87147&action=ed… Bug 14576: (follow-up) fix some typos and style Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #121 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87146&action=ed… Bug 14576: Update to use get_yaml_pref_hash Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #120 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87145&action=ed… Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86812|0 |1 is obsolete| | Attachment #86813|0 |1 is obsolete| | Attachment #86814|0 |1 is obsolete| | Attachment #86815|0 |1 is obsolete| | Attachment #86816|0 |1 is obsolete| | Attachment #87040|0 |1 is obsolete| | Attachment #87061|0 |1 is obsolete| | --- Comment #119 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87144&action=ed… Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet)
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 Paul Thornton <paul.thornton(a)educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.thornton(a)educampus.ie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8280] SRU should be filterable by Koha Item Type
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7890] Highlight required field in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com --- Comment #5 from Nick Clemens <nick(a)bywatersolutions.com> --- Does this one need a rebase because of the reversion of 22399? -- You are receiving this mail because: You are watching all bug changes.

1 0