March 2019 - Koha-bugs - lists.koha-community.org

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #12 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Liz Rea from comment #11) > Created attachment 87121 [details] [review] > Bug 10796: (QA Follow-up) Changing password recovery verbiage for users who > are disallowed online password resets Thank you!!! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #11 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87121&action=ed… Bug 10796: (QA Follow-up) Changing password recovery verbiage for users who are disallowed online password resets -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #10 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87120&action=ed… Bug 10796: Use $category->effective_change_password in the OPAC This patch makes the OPAC pages that rely on OpacPasswordChange use the current patron's category to make the decision to allow password change or not. It does so by making sure all the places in which OpacPasswordChange was used, use $logged_in_user->category->effective_change_password instead. Special attention is required on the case of opac-registration-verify.pl in which the use of an unblessed Koha::Patron object is changed in favour of the blessed object, so we can actually use the new method to make a decision on the text to display. To test: - Go through the OPAC pages, check that the password change strings and links are displayed only whne appropriate. - Sign off :-D Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #9 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87119&action=ed… Bug 10796: Handle can_change_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #8 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87118&action=ed… Bug 10796: Add Koha::Patron::Category->effective_change_password method This method checks whether the local $self->change_password is set to override the OpacPasswordChange syspref (i.e. if it is set to a bool) or undef, in which case it falls back to the value of the syspref To test: - Apply this patches - Make sure the DB is updated: $ updatedatabase - Update the schema files: $ dbic - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85389|0 |1 is obsolete| | Attachment #85390|0 |1 is obsolete| | Attachment #85391|0 |1 is obsolete| | Attachment #85392|0 |1 is obsolete| | --- Comment #7 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87117&action=ed… Bug 10796: DB update Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '19

28 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #82 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 87115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87115&action=ed… Bug 13895: (QA follow-up) Make the class plural Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #81 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 87114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87114&action=ed… Bug 13895: Fix test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #80 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 87113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87113&action=ed… Bug 13895: Adapt naming according to voted RFC -- You are receiving this mail because: You are watching all bug changes.

1 0